Seperated css #7258
Seperated css #7258
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7258 +/- ##
==========================================
+ Coverage 61.25% 81.6% +20.35%
==========================================
Files 97 97
Lines 5709 5600 -109
==========================================
+ Hits 3497 4570 +1073
+ Misses 2212 1030 -1182
|
|
@publiclab/reviewers Should I add the stylesheet link in application.html.erb? |
|
Can you add it where you removed the case from? Thanks!
…On Thu, Jan 16, 2020, 6:23 AM Suyash Choudhary ***@***.***> wrote:
@publiclab/reviewers <https://github.com/orgs/publiclab/teams/reviewers>
Should I add the stylesheet link in application.html.erb?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#7258?email_source=notifications&email_token=AAAF6JZ7PA4SCZBWZHKDYFLQ6A7TRA5CNFSM4KHRCIVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJDXF7A#issuecomment-575107836>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6JYUM2OZ2LAUXBLOKJDQ6A7TRANCNFSM4KHRCIVA>
.
|
|
@jywarren I already added the stylesheet link in notes.html.erb |
app/views/notes/_notes.html.erb
Outdated
| @@ -1,3 +1,4 @@ | |||
| <%= stylsheet_link_tag "notes", :media => "all" %> | |||
There was a problem hiding this comment.
It's good but you made a typo here. You need to write stylesheet
|
@Uzay-G I fixed the typo |
app/views/notes/_notes.html.erb
Outdated
| @@ -1,3 +1,4 @@ | |||
| <%= stylesheet_link_tag "notes", :media => "all" %> | |||
There was a problem hiding this comment.
I think you actually don't need to add this. Rails automatically adds these assets through the asset pipeline: https://guides.rubyonrails.org/asset_pipeline.html#controller-specific-assets
There was a problem hiding this comment.
Hmm. Well, i made the request because it seemed in the screenshots generated here that the styles were not appearing. I don't know that they're automatically included; we do have other styles that are for only specific pages, i believe?
https://stable.publiclab.org/tag/water-quality shows the way that page is supposed to look:
And i think the styles weren't getting loaded. Do you have this running locally and can you confirm? If not, we can check the latest auto-generated screenshots for this PR. Thanks for your patience on this!
There was a problem hiding this comment.
@jywarren This is the page that I am getting locally without including the stylesheet link
There was a problem hiding this comment.
And what happens when you include it?
There was a problem hiding this comment.
@Uzay-G It remains the same
There was a problem hiding this comment.
Yeah alright so we need to remove the stylesheet link tag
* Removed css from notes.html.erb * Added a new css file * Added stylesheet link * Fixed typo * removed stylesheet link
* Removed css from notes.html.erb * Added a new css file * Added stylesheet link * Fixed typo * removed stylesheet link
* Removed css from notes.html.erb * Added a new css file * Added stylesheet link * Fixed typo * removed stylesheet link
Fixes #7234 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!