-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate css in notes #7237
Separate css in notes #7237
Conversation
@publiclab/reviewers Kindly review the changes |
Codecov Report
@@ Coverage Diff @@
## master #7237 +/- ##
======================================
Coverage 81.5% 81.5%
======================================
Files 97 97
Lines 5602 5602
======================================
Hits 4566 4566
Misses 1036 1036
|
Screenshots 📸 (click to expand)7237-test_questions.png7237-test_embeddable_grids.png7237-test_signup.png7237-test_viewing_the_settings_page.png7237-test_tag_by_author_page.png7237-test_wiki_page_with_inline_grids.png7237-test_stats.png7237-test_viewing_the_dashboard.png7237-test_searching_an_item_from_the_homepage.png7237-test_signup_modal_form_validation.png7237-test_tag_stats.png7237-test_login_modal_form_validation.png7237-test_questions_shadow.png7237-test_login_modal.png7237-test_profile_page.png7237-test_comments.png7237-test_tags.png7237-test_signup_modal.png7237-test_wiki.png7237-test_methods.png7237-test_tag_page.png7237-test_blog_page_with_location_modal.png7237-test_tag_wildcard.png7237-test_signup_modal_disabled_submit_button_on_empty_username.png7237-test_embeddable_thumbnail_grids.png7237-test_front_page_with_navbar_search_autocomplete.png7237-test_spam_moderation_page.png7237-test_login.png7237-test_viewing_the_dropdown_menu.png7237-test_viewing_question_post.png7237-test_mobile_displays.png7237-test_simple-data-grapher_powertag.png7237-test_front.png7237-test_question_page.png7237-test_tag_contributors_page.png7237-test_blog.png7237-test_people.png7237-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help @sssash18
@VladimirMikulic @Uzay-G Thank you for your approval. |
@@ -15,60 +15,3 @@ | |||
</div> | |||
</div> | |||
<%= will_paginate notes, renderer: WillPaginate::ActionView::BootstrapLinkRenderer unless @unpaginated || (unpaginated ||= false) %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool..closing this |
Fixes #7234 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!