Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate css in notes #7237

Closed
wants to merge 2 commits into from
Closed

Separate css in notes #7237

wants to merge 2 commits into from

Conversation

sssash18
Copy link
Contributor

Fixes #7234 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@sssash18
Copy link
Contributor Author

@publiclab/reviewers Kindly review the changes

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #7237 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7237   +/-   ##
======================================
  Coverage    81.5%   81.5%           
======================================
  Files          97      97           
  Lines        5602    5602           
======================================
  Hits         4566    4566           
  Misses       1036    1036
Impacted Files Coverage Δ
app/models/node.rb 90.9% <100%> (ø) ⬆️

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @sssash18 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7237-test_questions.png

7237-test_embeddable_grids.png

7237-test_signup.png

7237-test_viewing_the_settings_page.png

7237-test_tag_by_author_page.png

7237-test_wiki_page_with_inline_grids.png

7237-test_stats.png

7237-test_viewing_the_dashboard.png

7237-test_searching_an_item_from_the_homepage.png

7237-test_signup_modal_form_validation.png

7237-test_tag_stats.png

7237-test_login_modal_form_validation.png

7237-test_questions_shadow.png

7237-test_login_modal.png

7237-test_profile_page.png

7237-test_comments.png

7237-test_tags.png

7237-test_signup_modal.png

7237-test_wiki.png

7237-test_methods.png

7237-test_tag_page.png

7237-test_blog_page_with_location_modal.png

7237-test_tag_wildcard.png

7237-test_signup_modal_disabled_submit_button_on_empty_username.png

7237-test_embeddable_thumbnail_grids.png

7237-test_front_page_with_navbar_search_autocomplete.png

7237-test_spam_moderation_page.png

7237-test_login.png

7237-test_viewing_the_dropdown_menu.png

7237-test_viewing_question_post.png

7237-test_mobile_displays.png

7237-test_simple-data-grapher_powertag.png

7237-test_front.png

7237-test_question_page.png

7237-test_tag_contributors_page.png

7237-test_blog.png

7237-test_people.png

7237-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@Uzay-G Uzay-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @sssash18

@sssash18
Copy link
Contributor Author

@VladimirMikulic @Uzay-G Thank you for your approval.

@@ -15,60 +15,3 @@
</div>
</div>
<%= will_paginate notes, renderer: WillPaginate::ActionView::BootstrapLinkRenderer unless @unpaginated || (unpaginated ||= false) %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, so actually we need to add a link to the new stylesheet here, so that the page is still visible. See how in this screenshot the styles are now missing?

The include should be:

<%= stylesheet_link_tag "notes", :media => "all" %>

Does that make sense?

@sssash18
Copy link
Contributor Author

@jywarren Actually due to some issue I had to fork my repo again , so I cant commit to this PR anymore.
I had created another PR #7258 .Kindly review the further changes there.
Sorry for the inconvenience. I have done your suggessted changes there.

@cesswairimu
Copy link
Collaborator

cool..closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To move css present in _notes.html.erb
6 participants