Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS fixed #5515

Merged
merged 1 commit into from
Jun 20, 2019
Merged

CSS fixed #5515

merged 1 commit into from
Jun 20, 2019

Conversation

divyabaid16
Copy link
Contributor

Fixes #5514 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

GIF of the change:
Peek 2019-04-18 14-16

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@plotsbot
Copy link
Collaborator

1 Message
📖 @divyabaid16 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

Copy link
Member

@CleverFool77 CleverFool77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@gauravano For further review.

Copy link
Contributor

@vansjyo vansjyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @divyabaid16. Just a suggestion. Instead of adding a negative margin, how about you try to remove the padding-left:20px from the li tag and instead add a padding-left to the anchor tag inside the li ... or something similar. That will give a much neater CSS. Please correct me if I'm wrong! Thanks.

@jywarren jywarren merged commit 85cf7d3 into publiclab:master Jun 20, 2019
@jywarren
Copy link
Member

Thanks I think this will work!

sagarpreet-chadha pushed a commit that referenced this pull request Jun 29, 2019
enviro3 pushed a commit to enviro3/plots2 that referenced this pull request Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decrease margin to css hover
5 participants