Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease margin to css hover #5514

Closed
divyabaid16 opened this issue Apr 18, 2019 · 4 comments · Fixed by #5515
Closed

Decrease margin to css hover #5514

divyabaid16 opened this issue Apr 18, 2019 · 4 comments · Fixed by #5515
Labels
CSS has-pull-request issues which already have a pull request solving it

Comments

@divyabaid16
Copy link
Contributor

Hover does not cover the entire thing. Some portion of the book icon is not aligend with css.
Peek 2019-04-18 14-19

@divyabaid16 divyabaid16 mentioned this issue Apr 18, 2019
5 tasks
@grvsachdeva grvsachdeva added the has-pull-request issues which already have a pull request solving it label Apr 23, 2019
@grvsachdeva
Copy link
Member

Hey @divyabaid16, please see #5166. Also, if you're interested, you can help in completing that PR too. Thanks!

@divyabaid16
Copy link
Contributor Author

@gauravano so this issue doesn't need to be solved as in #5516 we are just removing the background on hover.
Also, should I create a new PR for solving #5166 as per the suggestions you have asked for ?
Thanks!

@grvsachdeva
Copy link
Member

@gauravano so this issue doesn't need to be solved as in #5516

you mean #5166 right?

Actually, you can collaborate on already existing PR. Thanks!

@divyabaid16
Copy link
Contributor Author

Okay @gauravano I will do this within few days.
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS has-pull-request issues which already have a pull request solving it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants