Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip over delete button of comment #4992 #5014

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Add tooltip over delete button of comment #4992 #5014

merged 1 commit into from
Mar 11, 2019

Conversation

cassianoblonski
Copy link
Contributor

@cassianoblonski cassianoblonski commented Mar 11, 2019

Fixes #4992

image

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

3 Messages
📖 @cassianoblonski Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Your pull request is on the master branch. Please make a separate feature branch) with a descriptive name like new-blog-design while making PRs in the future.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@cassianoblonski cassianoblonski changed the title Add tooltip over delete button of comment #4992 [WIP] Add tooltip over delete button of comment #4992 Mar 11, 2019
@cassianoblonski
Copy link
Contributor Author

@gauravano can you review this for me, for the future PRs now i'm aware of the feature branch unique name.

@cassianoblonski cassianoblonski changed the title [WIP] Add tooltip over delete button of comment #4992 Add tooltip over delete button of comment #4992 Mar 11, 2019
Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@grvsachdeva grvsachdeva merged commit d0504e9 into publiclab:master Mar 11, 2019
@grvsachdeva
Copy link
Member

Merged 🎉 🎈 💯 👍

We would love to have more help from you. So, if you're interested in working on more issues, then you can look at https://github.com/publiclab/plots2/issues and start working on those issues which you find interesting. If you find any issue complicated or think you need more info, then feel free to mention @publiclab/plots2-reviewers.

Thanks!

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants