Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip over delete button of comment #4992

Closed
5 tasks
grvsachdeva opened this issue Mar 10, 2019 · 10 comments
Closed
5 tasks

Add tooltip over delete button of comment #4992

grvsachdeva opened this issue Mar 10, 2019 · 10 comments
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. has-pull-request issues which already have a pull request solving it HTML

Comments

@grvsachdeva
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

Add the tooltip "Delete comment" for comment delete button just like we have for other options on the comment

tooltip_add

Also, attach the screenshot of the updated view by going over to any research note/question on localhost and taking a screenshot of the comment posted over there

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@grvsachdeva grvsachdeva added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML CSS labels Mar 10, 2019
@grvsachdeva
Copy link
Member Author

This issue is created for @cassianoblonski. Thanks!

@cassianoblonski
Copy link
Contributor

i'm working on this.

@cassianoblonski
Copy link
Contributor

cassianoblonski commented Mar 11, 2019

its fine if I add the tooltip over edit comment button too, or better leave for another first timer?

edit: I followed the installation doc on the Readme and got a problem on:
Standard Installation
4. Install gems with bundle install --without production mysql
needed to change to 'mysql2' to work, otherwise I got the error "mysql2 is not part of the bundle. Add it to your Gemfile" (the mysql2 is on the Gemfile under production group)

I can fix the Readme too if needed just open a issue or reply me here and then I create the PR with both fixes or with your instructions.

@grvsachdeva
Copy link
Member Author

its fine if I add the tooltip over edit comment button too, or better leave for another first timer?

Let's keep it for another first-timer.

edit: I followed the installation doc on the Readme and got a problem on:
Standard Installation

  1. Install gems with bundle install --without production mysql
    needed to change to 'mysql2' to work, otherwise I got the error "mysql2 is not part of the bundle. Add it to your Gemfile" (the mysql2 is on the Gemfile under production group)
    I can fix the Readme too if needed just open a issue or reply me here and then I create the PR with both fixes or with your instructions.

The fix has been merged recently, so update your branch and then try. Thanks!

@grvsachdeva
Copy link
Member Author

@cassianoblonski

@shridhiaggarwal
Copy link

Hi @gauravano , Is this issue still open to work ?
and may i solve this issue ?

@grvsachdeva grvsachdeva added the has-pull-request issues which already have a pull request solving it label Mar 11, 2019
@grvsachdeva
Copy link
Member Author

Hi @aggarwal19 , this issue is assigned to @cassianoblonski . But, we would love to have your help with other issues, you can find more issues at https://code.publiclab.org/#r=all and if you can't find any unclaimed issue there, feel free to comment below or in the Gitter channel - https://gitter.im/publiclab/publiclab, so that we can try to help you in finding a good issue to start with or maybe create a new issue for you.

Thanks!

@shridhiaggarwal
Copy link

@gauravano , it would great if you could provide me the first timer only issue .
Thank you

@grvsachdeva
Copy link
Member Author

Added your name to the list @aggarwal19. Will ping you soon with an FTO. Thanks!

@Jenniline
Copy link

Hi I am an Outreachy applicant new to open source and willing to learn. @gauravano can i work on this issue too or be assigned a task to on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. has-pull-request issues which already have a pull request solving it HTML
Projects
None yet
Development

No branches or pull requests

4 participants