Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(modal): Use new anchor class for ask question on wiki page #4403

Merged
merged 1 commit into from
Dec 26, 2018

Conversation

kevinzluo
Copy link
Collaborator

Fixes #4230 (<=== Add issue number here)

Replaces the changes in #4239 using the new anchor class.

Basic flow:
askaquestionwikipage

Alternate Flow:
askaquestionwikipage2

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@ghost ghost assigned kevinzluo Dec 26, 2018
@ghost ghost added the in progress label Dec 26, 2018
@plotsbot
Copy link
Collaborator

2 Messages
📖 @kevinzluo Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@SidharthBansal SidharthBansal merged commit 903cd43 into publiclab:master Dec 26, 2018
@ghost ghost removed the in progress label Dec 26, 2018
@SidharthBansal
Copy link
Member

Awesome great!!!
Kevin it will be great if you can look backward and see which PRS needs to be made again like this one.
They can be either by you or by any one else.
You can send those PR fixes too yourself.

Thanks a lot

@SidharthBansal SidharthBansal added this to the OAuth milestone Dec 26, 2018
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants