-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modal for ask question on wikis page #4239
Conversation
Generated by 🚫 Danger |
@SidharthBansal Could you take a look and add the issue (#4230) to the GCI dashboard? |
Please take this task on gci so that @publiclab/mentors can reward you on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, changes looks good to me. Thanks for your work.
@jywarren @gauravano can you please review this and merge this?
@SidharthBansal I can't seem to find the task. Could you give me a link? It might be because I created the issue for this PR. The issue is #4230 . Sorry for the inconvenience. |
https://codein.withgoogle.com/dashboard/tasks/6462885212454912/ |
No problem, and thank you! I am awake now 😄 |
This is perfect!!! |
Redone in #4403 with new changes. |
Oh thanks. |
* Add login modal to add activity and ask a question on wiki pages * Add for only question button
Fixes #4230
Ask Question Basic Flow:
Ask Question Alternate Flow:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!