Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal for ask question on wikis page #4239

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

kevinzluo
Copy link
Collaborator

@kevinzluo kevinzluo commented Dec 10, 2018

Fixes #4230

Ask Question Basic Flow:
askquestionbasic

Ask Question Alternate Flow:
askquestionalternate

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@ghost ghost assigned kevinzluo Dec 10, 2018
@ghost ghost added the in progress label Dec 10, 2018
@kevinzluo kevinzluo mentioned this pull request Dec 10, 2018
4 tasks
@plotsbot
Copy link
Collaborator

2 Messages
📖 @kevinzluo Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@kevinzluo
Copy link
Collaborator Author

@SidharthBansal Could you take a look and add the issue (#4230) to the GCI dashboard?
Thanks!

@kevinzluo kevinzluo mentioned this pull request Dec 10, 2018
4 tasks
@SidharthBansal
Copy link
Member

Please take this task on gci so that @publiclab/mentors can reward you on this.

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, changes looks good to me. Thanks for your work.
@jywarren @gauravano can you please review this and merge this?

@kevinzluo
Copy link
Collaborator Author

kevinzluo commented Dec 10, 2018

@SidharthBansal I can't seem to find the task. Could you give me a link? It might be because I created the issue for this PR. The issue is #4230 . Sorry for the inconvenience.

@SidharthBansal
Copy link
Member

https://codein.withgoogle.com/dashboard/tasks/6462885212454912/
Will approve it right now.
Sorry, I was having lunch that time.

@kevinzluo
Copy link
Collaborator Author

No problem, and thank you! I am awake now 😄

@SidharthBansal SidharthBansal added this to the OAuth milestone Dec 10, 2018
@jywarren
Copy link
Member

This is perfect!!!

@kevinzluo
Copy link
Collaborator Author

Redone in #4403 with new changes.

@SidharthBansal
Copy link
Member

Oh thanks.

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Add login modal to add activity and ask a question on wiki pages

* Add for only question button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants