Separating edit and new partial for the sign up modal

[SidharthBansal]

Fixes #4173(<=== Add issue number here)

[plotsbot]

	2 Messages
📖	@SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[SidharthBansal]

@JonathanXu1 I rectified the error.
Now I guess everything is fine.
@sagarpreet-chadha can you please review this?
@oorjitchowdhary it will be great if you can

• Sign Up form validations are working fine for incorrect input fields(testing)
• Sign Up modal validations are working fine for incorrect input fields(testing)
• Sign Up form signs a user in successfully(testing)
• Sign Up modal signs in a user successfully(testing)
• Sign Up works well on all the webpages(testing)
• Sign Up is redirected to the same page after user signs up(return_to)(testing)
• Check on the localhost(testing) for all above scenarios discussed.
• Check on the unstable branch(testing) for all above scenarios discussed.
• Check functionality of Oauth providers on the unstable branch.(testing)
  So that I can reward you.
  @JonathanXu1 ones @oorjitchowdhary tests it. You can close your pr and create one pr for the integration of login and signup modal.
  Don't forget to push the changes of this pr into your integration pr @JonathanXu1.
  Please claim the task on the GCI dashboard so that @JonathanXu1 I can give you rewards.

[jonxuxu]

• Sign Up form validations are working fine for incorrect input fields(testing)
  Page refreshes, modal closes
• Sign Up modal validations are working fine for incorrect input fields(testing)
  Page refreshes, modal closes
• Sign Up form signs a user in successfully(testing)
  Page refreshes, modal closes
• Sign Up modal signs in a user successfully(testing)
  Should work, but unable to verify
• Sign Up works well on all the webpages(testing)
  Should work, but unable to verify
• Sign Up is redirected to the same page after user signs up(return_to)(testing)
  Url matches original directory
• Check on the localhost(testing) for all above scenarios discussed.
  @SidharthBansal is this the check for the master branch?
• Check on the unstable branch(testing) for all above scenarios discussed.
  1,2,3 ERROR
  4,5,6 should work but redirects to https://localhost/register?return_to=/ instead of c9 link
• Check functionality of Oauth providers on the unstable branch.(testing)
  
  400 error on both modals and respective signup and login pages
• return to works properly

[kevinzluo]

Hi there!

I will try these changes to help out too.

[SidharthBansal]

@JonathanXu1 testing is done by @oorjitchowdhary in these prs. You can focus on the coding stuff. Lets divide task equally.

[SidharthBansal]

@JonathanXu1 404 error is for google.
Can you try other providers?
I hope other providers are working fine.

[jonxuxu]

@SidharthBansal I've created a new PR from this branch. Can I start work on the integration there? #4184

[SidharthBansal]

Thanks @oorjitchowdhary please claim the task and get rewards.
@JonathanXu1 I will be reviewing it there.

[oorjitchowdhary]

Thanks @oorjitchowdhary please claim the task and get rewards.

I've claimed the sign up task

[SidharthBansal]

Moved to #4209