Integrate Sign Up and Login Modals

[SidharthBansal]

There are two options

1. We will have two separate buttons throughout the website. One for signup and one for login. With the login, we will attach the login modal and with the signup we will attach the signup modal.
   As the user needs to open up the sign up modal once in their lifetime, the modal will usually be short as it will be login modal. Once the modal will be lengthy at the time of sign up.
2. We will integrate the login and the signup modal into one modal. Next, we will change login and signup option both with single option login/signup which links to the modal.
   This will result in users to see large modals each time due to signup.
   Most websites have integrated signup/login modal, what do you say @oorjitchowdhary @JonathanXu1 @jywarren ?

[SidharthBansal]

I think there is a need to integrate because at many places we have a single button.

[oorjitchowdhary]

As the user needs to open up the sign up modal once in their lifetime, the modal will usually be short as it will be login modal. Once the modal will be lengthy at the time of sign up.

I didn't understand this..

2. We will integrate the login and the signup modal into one modal. Next, we will change login and signup option both with single option login/signup which links to the modal.
   This will result in users to see large modals each time due to signup.

Yes that sounds great

[SidharthBansal]

I didn't understand this..

We can have two different modals for sign up and login.
We will not integrate them into 1 modal.

[coderjolly]

@SidharthBansal Can someone else also take this, other than GCI ?

[SidharthBansal]

@coderjolly this task needs to be done after Sign Up Modal and @JonathanXu1 is working on this task.
@coderjolly only GCI students can take GCI tasks.

[SidharthBansal]

@JonathanXu1 can you please share the gifs which you are planning for this issue.
We can enhance it here side by side until that pr isn't merged

[jonxuxu]

Here's the gif of the current version of login and signup modals that I'm working on:

Keep in mind that the signup modal only works on the /signup page.

[SidharthBansal]

I am asking you what are you planning for integrated view.
I know the current state. Sorry, for the misunderstanding

[jonxuxu]

I'm thinking we have the current login modal pop up when the button is clicked. Then, when the user clicks "or sign up", the contents change to the signup modal. What do you think?

[oorjitchowdhary]

@JonathanXu1 That seems great

[SidharthBansal]

Sounds perfect

[SidharthBansal]

You need to do two things
sign up should redirect back to the login modal
Login modal linked to the sign up modal.

[SidharthBansal]

@JonathanXu1 for wide variety of issues which we have created, in those then login modal can be linked.
What do you say?

[jonxuxu]

sign up should redirect back to the login modal

in those then login modal can be linked

Sorry could you clarify this?

[SidharthBansal]

We have a login button on the signup modal, we need to link it to the login modal. On clicking on that button it should close the signup modal and open up the login modal.
And other action is completely opposite of it.

[oorjitchowdhary]

We have a login button on the signup modal, we need to link it to the login modal. On clicking on that button it should close the signup modal and open up the login modal.
And other action is completely opposite of it.

Yess

[oorjitchowdhary]

Also, @SidharthBansal Can I start working on the link login modal issues?
Link login modal to various locations

[SidharthBansal]

Yeah sure.

…

On Sun, Dec 9, 2018 at 8:23 PM Oorjit Chowdhary ***@***.***> wrote: Also, @SidharthBansal <https://github.com/SidharthBansal> Can I start working on the link login modal issues? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4184 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ1KTR4FUgr16u5p0nlPMduSZyzR5ks5u3SPLgaJpZM4ZJh87> .

[jonxuxu]

Oh I see. Can I implement this issue in the signup modal branch we're working on since we have both signup and login modals appearing there?

[SidharthBansal]

It will be great if you will be pushing changes in the same pr.

[SidharthBansal]

Or create a new pr with those changes and close my pr.

[jonxuxu]

I can push the changes to my existing pr if you'd like. It's closed though.

[SidharthBansal]

Then you create a new pr. Link it to my pr. Close my pr.
Paste in the whole checkboxes list of @oorjitchowdhary and yours combined there.
We need to check all of them before the pr is ready to be merged.

[SidharthBansal]

In the new pr created please first rebase it to the master
and have same identical changes of my pr first. Then I will review it. Once you get the 👍 you can start working on the integration part.
Does it makes sense?

[jonxuxu]

I've added it here: #4209. Also I don't think I have permission to close #4203
Can I start on the integration work?

[SidharthBansal]

Yeah sure.