Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated notes.html.erb which now highlights the selected tab #3973

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Updated notes.html.erb which now highlights the selected tab #3973

merged 1 commit into from
Nov 15, 2018

Conversation

oorjitchowdhary
Copy link
Member

@oorjitchowdhary oorjitchowdhary commented Nov 15, 2018

Fixes #3526 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@oorjitchowdhary
Copy link
Member Author

@SidharthBansal @jywarren This is the PR... Only the notes file is edited...

@oorjitchowdhary
Copy link
Member Author

image
Now the tabs do not change

@plotsbot
Copy link
Collaborator

3 Messages
📖 @oorjitchowdhary Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Your pull request is on the master branch. Please make a separate feature branch) with a descriptive name like new-blog-design while making PRs in the future.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@oorjitchowdhary
Copy link
Member Author

Pls merge this.. Thanks

@oorjitchowdhary
Copy link
Member Author

@SidharthBansal @jywarren

@jywarren
Copy link
Member

Amazing! Perfect!!!

@jywarren jywarren merged commit 9833c36 into publiclab:master Nov 15, 2018
@oorjitchowdhary
Copy link
Member Author

Thanks a lot @jywarren .. Hope to contribute more 😄

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants