Highlight selected tab #3526
Comments
|
@igniteeng000 can u please explain more about this issue |
|
Highlight tab which is selected just like Notes |
|
Hi @igniteeng000, nice catch, would you like to solve this issue by yourself or a FTO ? Thanks! |
|
I want to add this issue for gci-candidate. |
|
ok, cool! |
|
Please add link to file also in issue body. Thanks! |
|
@igniteeng000 if you are creating a gci candidate issue, please add following lines in the issue body so that other people will not start solving it: |
|
@igniteeng000 Please add this and other gci-candidate issue you make to #3276 as well as to gci dashboard. Nice Work!! |
|
yes this is great!
…On Mon, Oct 1, 2018 at 3:44 PM Sourav Sahoo ***@***.***> wrote:
@igniteeng000 <https://github.com/igniteeng000> Please add this and other
gci-candidate issue you make to #3276
<#3276> as well as to gci
dashboard. Nice Work!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3526 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ8exZ8eKcvnf5qR3m14MpzR58iFTks5ugnCBgaJpZM4W-WH->
.
|
|
I would like to work on this, if this issue is still open. |
|
Sorry, you can't commit changes for this issue. Maybe take a look at one of these? |
|
No problem. Thanks for informing @SidharthBansal 👍 |
|
This task is published on GCI dashboard. Thanks all. |
|
Is this issue still open? |
|
Yes |
|
@deltrix Now you can find this issue in gci dashboard. Go ahead fix this issue. |
|
I'd like to work on this.. I'm a GCI candidate. |
|
Go ahead
…On Fri, Nov 9, 2018, 4:14 PM Oorjit Chowdhary ***@***.***> wrote:
I'd like to work on this.. I'm a GCI candidate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3526 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ9OqjwPkWf2S_3QfXtWBPjyX8PPUks5utVx6gaJpZM4W-WH->
.
|
|
@SidharthBansal Where is the code file? and how would I submit the work? Should I create a pull request? |
|
Yeah you need to create a pull request. |
|
I guess https://github.com/publiclab/plots2/blob/master/app/views/search/notes.html.erb is the view. |
|
There's /notes.html.erb and also /wiki.html.erb ... so I need to edit both right? |
|
Yes. |
|
You need to push it to publiclab/master.
You created PR to your own fork.
…On Fri, Nov 9, 2018, 10:08 PM Oorjit Chowdhary ***@***.***> wrote:
@SidharthBansal <https://github.com/SidharthBansal> pls review my task....
oorjitchowdhary#1 <https://github.com/oorjitchowdhary/plots2/pull/1>
oorjitchowdhary#2 <https://github.com/oorjitchowdhary/plots2/pull/2>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3526 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQxJcICP7qH4AiC3IY6Y844zBEMm6ks5uta99gaJpZM4W-WH->
.
|
|
Oh ok my bad |
We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.Please describe the problem (or idea)
It will be good if the selected tab is highlighted.
Please show us where to look
https://publiclab.org/search/science%20community?order=default
What's your PublicLab.org username?
igniteeng000
https://github.com/publiclab/plots2/blob/a128622eb132eef4733c0067e2c6b2c1669d3042/app/views/search/notes.html.erb
https://github.com/publiclab/plots2/blob/a128622eb132eef4733c0067e2c6b2c1669d3042/app/views/search/wikis.html.erb
Browser, version, and operating system
windows 10, chrome
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
To learn how to write really great issues, which increases the chances they'll be resolved, see:
https://publiclab.org/wiki/developers#Contributing+for+non-coders
The text was updated successfully, but these errors were encountered: