Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup icons position changed #3012 #3023

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Signup icons position changed #3012 #3023

merged 2 commits into from
Jul 10, 2018

Conversation

dewanhimanshu
Copy link
Collaborator

@dewanhimanshu dewanhimanshu commented Jul 10, 2018

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@dewanhimanshu
Copy link
Collaborator Author

screenshot from 2018-07-10 14-40-42
screenshot from 2018-07-10 14-40-21

@plotsbot
Copy link
Collaborator

2 Messages
📖 @dewanhimanshu Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@SidharthBansal
Copy link
Member

@jywarren can you kindly review this and suggest changes? Is there anything else we want in signup view?

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@steviepubliclab
Copy link
Contributor

This looks great to me!

@jywarren jywarren merged commit 81f88db into publiclab:master Jul 10, 2018
@jywarren
Copy link
Member

Awesome, thank you so much!!! 🎉 🎉 🎉

@jywarren
Copy link
Member

We'd love to have more help from you if you're interested! We're working on a couple bugs at #2969 or #3013 ?

@SidharthBansal
Copy link
Member

@jywarren so we are completed with the signup page frontend work??? OR any other changes are needed?

@dewanhimanshu
Copy link
Collaborator Author

Thank you everyone

@SidharthBansal SidharthBansal added this to the OAuth Login milestone Jul 11, 2018
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* swap position of form and icons

* added ruby env to production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants