Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift the providers up on sign up page #3012

Closed
7 tasks
SidharthBansal opened this issue Jul 9, 2018 · 6 comments
Closed
7 tasks

Shift the providers up on sign up page #3012

SidharthBansal opened this issue Jul 9, 2018 · 6 comments
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML summer-of-code

Comments

@SidharthBansal
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Please describe the problem (or idea)

It is easy to sign up with the providers like facebook etc. than with email and password. So, we need to shift them up
image
image
Also, centre align the buttons

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Swap the providers and email-password sign in
    app/views/users/new.html.erb

  • Centre align the provider icons

  • Make the text on the page looks good

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)
Part of #2676.

@SidharthBansal SidharthBansal added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML CSS labels Jul 9, 2018
@SidharthBansal SidharthBansal added this to the OAuth Login milestone Jul 9, 2018
@dewanhimanshu
Copy link
Collaborator

can i try this?

@SidharthBansal
Copy link
Member Author

Yes

@chrisbridges
Copy link

So you would essentially like to swap the "Sign up with" option and the form? Putting the "Sign up with" buttons on top?

@SidharthBansal
Copy link
Member Author

Right

@bhargavn
Copy link

Can I try this?

@SidharthBansal
Copy link
Member Author

@dewanhimanshu is working on this. So, other guys can take other issues

jywarren pushed a commit that referenced this issue Jul 10, 2018
* swap position of form and icons

* added ruby env to production
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this issue May 5, 2019
* swap position of form and icons

* added ruby env to production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML summer-of-code
Projects
None yet
Development

No branches or pull requests

4 participants