Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature to sidebar, questions code overhaul #1335

Merged
merged 6 commits into from
Mar 16, 2017
Merged

add feature to sidebar, questions code overhaul #1335

merged 6 commits into from
Mar 16, 2017

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Mar 14, 2017 •
edited
Loading

Fixes #1304, fixes #897 and closes #929

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue

@PublicLabBot
Copy link

PublicLabBot commented Mar 14, 2017 •
edited
Loading

4 Messages
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution!
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the format: Fixes #123.
📖 You have added multiple commits. It’s helpful to squash them if the individual changes are small.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@jywarren jywarren mentioned this pull request Mar 14, 2017
Closed
@jywarren jywarren mentioned this pull request Mar 16, 2017
Merged
3 tasks
@jywarren
Copy link
Member Author

Yay. Merging.

@jywarren jywarren merged commit f40642c into publiclab:master Mar 16, 2017
vaibhavgeek pushed a commit to vaibhavgeek/plots2 that referenced this pull request Mar 23, 2017
@jywarren @vaibhavgeek
add feature to sidebar, questions code overhaul (publiclab#1335)
bde4487 
* add feature to sidebar

* reorg of questions assets

* work on questions by path not session

* feature sidebar final fixes

* test fix

* questions fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/questions page does not show any questions Append keywords in questions tag filter as GET URL parameters
2 participants
@jywarren @PublicLabBot