-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/questions page does not show any questions #1304
Comments
@ebarry Did you try switching tabs? This is not expected. |
Thanks @ryzokuken upon your encouragement i tried all the tabs again, and then restarted my computer in case the problem was somehow in me running out of memory (i really have excessive #s of tabs going right now). Unfortunately, the problem is persisting! |
@ebarry Did you switch browser tabs? There are quite a few tabs (five, to be precise) in the questions list itself. Try switching them. Maybe the recently asked questions don't show up but the recently answered ones do? |
This is a known issue related to how the questions page uses session
storage; related:
#897
#929
I think we need to reorganize and break up some of these issues so this
gets solved!
…On Tue, Feb 28, 2017 at 2:24 PM, Ujjwal Sharma ***@***.***> wrote:
@ebarry <https://github.com/ebarry> Did you switch browser tabs? There
are quite a few tabs (five, to be precise) in the questions list itself.
Try switching them. Maybe the recently asked questions don't show up but
the recently answered ones do?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1304 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-jXVREwqe0sbiCEJmVI6Ebyv0WMks5rhHR2gaJpZM4MOsUX>
.
|
@jywarren Let's talk this over and try to fix this in parts. Maybe we could get a few FTOs out of this? |
Agreed. I would super love to start by creating a parallel URL based system for searching/sorting questions, so that when entering tags, instead of in the session, it's represented in the URL. Once we build and test that (which should be pretty simple) we can then just strip out the session stuff and default to that. But is there a reason not to use the existing questions-by-tags listings at, for example, https://publiclab.org/questions/tag/spectrometry ? Could we simply remove session code for initial pageview and then have the form go to these pages? |
Yeah, I mean, not storing data in the session but rather rendering the questions on-the-fly using data in the URL (sorry if I'm misunderstanding you) seems not only the easier task, but quite natural. Let's work on this. Regarding the older listings, we would need to make a newer way of listing questions anyway, but maybe we could keep this one as well (for now, atleast). It would not be a nice thing to remove that route without notifying users of this decision and giving them a change to update all instances of such a URL. What do you say? |
Well, currently since it uses sessions, the /questions page doesn't go to a unique url, so we could just direct folks to |
Okay, I got you. Also, don't know if it's happening to anyone else, but I was unable to remove the selected tags in the session by clicking on the cross. The page just re-rendered without the tag actually being removed. All these problems would be solved and searching would be further simplified should we choose to use the redirection method instead. |
@jywarren I narrowed down https://github.com/publiclab/plots2/blob/master/app/views/tag/_sorting.html.erb#L17-L48 as the part where the session-based tag selection happens. Is that it? If that's the case, maybe we could remove all the session management code and replace it with a simple redirect to |
Sure, that sounds great. Thanks!!!
…On Sat, Mar 4, 2017 at 12:20 PM, Ujjwal Sharma ***@***.***> wrote:
@jywarren <https://github.com/jywarren> I narrowed down
https://github.com/publiclab/plots2/blob/master/app/views/
tag/_sorting.html.erb#L17-L48 as the part where the session-based tag
selection happens. Is that it? If that's the case, maybe we could remove
all the session management code and replace it with a simple redirect to
/questions/tag/#{query} instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1304 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ78ZMOSWWgG3lYulzZRt1ZgM5qXhks5riZ1rgaJpZM4MOsUX>
.
|
What happened just before the problem occurred
I visited https://publiclab.org/questions/ and no questions are shown.
Seems like when i click back and forth between "Recently asked" and "Recently answered", the yellow question blocks flicker for an instant before the page is just blank again. I wonder if this is happening for anyone else?
Relevant URLs
https://publiclab.org/questions/
PublicLab.org username
liz
Browser, version, and operating system
Chrome
The text was updated successfully, but these errors were encountered: