Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize searchbox placeholder in subscriptions #5191

Closed
5 tasks
CleverFool77 opened this issue Mar 20, 2019 · 13 comments · Fixed by #8554
Closed
5 tasks

Capitalize searchbox placeholder in subscriptions #5191

CleverFool77 opened this issue Mar 20, 2019 · 13 comments · Fixed by #8554
Labels
assigned CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML

Comments

@CleverFool77
Copy link
Member

CleverFool77 commented Mar 20, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update .

  • The input form for enter tags is in lowercase

Screenshot from 2019-03-20 13-33-27

  1. Change this line https://github.com/publiclab/plots2/blob/master/config/locales/en.yml#L662 to enter_tags: "Enter tags"
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@IshaGupta18
Copy link
Collaborator

@vaarigupta you can work on this one!

@IshaGupta18 IshaGupta18 added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML CSS labels Mar 20, 2019
@vaarigupta
Copy link

@vaarigupta you can work on this one!
Thanks a lot .I look into it and continue with it

@techchic
Copy link

Hey can I work on this as well?

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented Mar 21, 2019 via email

@Linda-Ikechukwu
Copy link

Hi, has this issue been resolved, if not can I be assigned to it? . I'm an outreachy intern.

@CleverFool77
Copy link
Member Author

Hi @Linda-Ikechukwu Can you check that whether there is change in development in latest fetched changes? If not, then you can move forward or else this issue would close down.

Thanks !!

@cesswairimu
Copy link
Collaborator

@Linda-Ikechukwu, it seems like this is not fixed yet..Go ahead and work on it. Thanks

@loranazarenko
Copy link
Contributor

Hello! Can i work with this issue?

@cesswairimu
Copy link
Collaborator

Hi @loranazarenko , this one is already being worked on by @Linda-Ikechukwu. You can browse for another issue.

@SidharthBansal
Copy link
Member

Is this issue solved?

@redahaq
Copy link

redahaq commented Feb 2, 2020

Hi @CleverFool77 , has this issue been resolved? If not I'd love to work on it. Thank you.

@stale stale bot added the stale label Oct 7, 2020
@publiclab publiclab deleted a comment from stale bot Oct 7, 2020
@cesswairimu cesswairimu removed the stale label Oct 7, 2020
@shubhangikori
Copy link
Contributor

Hey! Can I work on this issue?

@cesswairimu
Copy link
Collaborator

Hi @shubhangikori yes you could work on it. But lets leave the alignment as left aligned. I see we are using left alignment for all of our search boxes. This is what you need to do for this issue.

Update

Todo: Change this line https://github.com/publiclab/plots2/blob/master/config/locales/en.yml#L662 to enter_tags: "Enter tags"

Thanks

@cesswairimu cesswairimu changed the title Align the enter tags input section in subscriptions Capitalize searchbox placeholder in subscriptions Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML
Projects
None yet