-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove background from wiki links shown on profile sidebar #4980
Comments
This issue is created for @EngrEric. Thanks! |
Thanks, I will be working on it |
@gauravano, I am trying to setup the project locally on my computer but has this error |
@gauravano please is there a slack channel here |
Hello,I would like to help with this or any other issue. @gauravano Would you like to create an issue for me? Thank you! |
Hi @EngrEric, please update your fork as this issue is recently resolved. @luanafaustini you can start working on #5051. Thanks! |
@gauravano is there another issue i should work on? |
have you raised fix for this issue? @EngrEric |
@gauravano, no. |
Rebase your local branch with master as fix for the issue is already merged |
@gauravano Do I still have to present it as my contribution at outreachy or you will create another one for me. |
You have to solve this or another issue and submit it at outreachy portal |
Cool, in want to solve this one. |
Great! Give it a try and if you get stuck on updating PR branch then let me know. Thanks! |
Hello! I would like to work on this if not solved or any other first timer issue. I have experience in HTML and CSS through school projects and will try my best. |
Hi @Priyak5, I have added your name to #4963 (comment) and will ping you soon with a new/appropriate issue. Thanks! |
hello @gauravano I am an outreachy applicant and excited to work on this issue. How can I start contributing ? |
Hey @vaarigupta, you can start working on this #5191 . Thanks! |
I
Ya sure I look into it |
@gauravano |
@gauravano . |
Hi @EngrEric, you have to make a timeline where you'll be mentioning which tasks(from #4922) you'll be doing in each week. Also, dedicate some time to testing with each week if you think that week's task requires it. Or, you can plan for tests at end (if testing is required) Start making a timeline in your proposal and I or some other mentor will review and suggest the changes. Thanks! |
Hi, this issue is still open, can I take it up? I'm an outreachy intern applicant |
@avats-dev Thank you for assigning me 👍 |
Hi @avats-dev it seems like this issue has already been resolved |
Thanks for everyone's work on this, this issue is fully resolved, and i'm going to close it. Thanks all! |
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update:
On /profile/[username] in the sidebar, links display colored background on hover, let's remove the background color from the links
Update this line of code
https://github.com/publiclab/plots2/blob/master/app/views/users/profile.html.erb#L284
so that on hovering over the links, no color is shown.
Also, try to shift the icon in the colored zone and upload the screenshot asking which view is looking better?
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
🤔❓ Questions?
Leave a comment below!
Is someone else already working on this?
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
The text was updated successfully, but these errors were encountered: