Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _footer.html.erb #606

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/views/layouts/_footer.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,15 @@
<p>
Having trouble? <a href="http://github.com/publiclab/mapknitter/issues">Submit bugs here</a>.
</p>
<p>
MapKnitter uses <a href="http://gdal.org">GDAL</a>, <a href="http://leafletjs.com">Leaflet</a>, <a href="http://rubyonrails.org">Ruby on Rails</a>, <a href="http://imagemagick.org">ImageMagick</a>, and other open source software, and makes extensive use of the open source font <a href="http://www.theleagueofmoveabletype.com/junction">Junction</a>.</p>
<p>
+ MapKnitter uses <a href="http://gdal.org">GDAL</a>, <a href="http://leafletjs.com">Leaflet</a>, <a href="http://rubyonrails.org">Ruby on Rails</a>, <a href="http://imagemagick.org">ImageMagick</a>, and other open source software, and makes extensive use of the open source font <a href="http://www.theleagueofmoveabletype.com/junction">Junction</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of having this in one huge line, but let's wait on someone elses review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alaxalves. What would be your preferred solution, because it does look good to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just break the lines, that's all.

+ </p>
+ <h3>Feeds</h3>
+ <p><a href="/feeds/all">All maps</a></p>
+ <p><a href="/feeds/license/public-domain">Public domain maps</a></p>
+ <p><a href="/feeds/license/cc-by-sa">CC-BY-SA maps</a></p>
+ <p><a href="/feeds/license/cc-by">CC-BY maps</a></p>
+ <p><a href="/feeds/tag/barataria">Maps of Barataria Bay</a></p>
</div>
<div class="col-md-4">
<h3>Contributing</h3>
Expand Down