Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _footer.html.erb #606

Closed
wants to merge 1 commit into from
Closed

Conversation

nycbeardo
Copy link

@nycbeardo nycbeardo commented May 14, 2019

added RSS feed links to Update_footer

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

added RSS feed links to Update_footer
@welcome
Copy link

welcome bot commented May 14, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codeclimate
Copy link

codeclimate bot commented May 14, 2019

Code Climate has analyzed commit 82cb7fe and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #606 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files          32       32           
  Lines        1279     1279           
=======================================
  Hits          911      911           
  Misses        368      368

@alaxalves
Copy link
Member

@nycbeardo Could this edit the template and link the issue you've solved and such? Thnx 😄

@alaxalves
Copy link
Member

Hey @nycbeardo I meant to link the issue like this: Fixes #434. Make sure you do this on your next MRs. Anyway this look ok to me ;)

<p>
MapKnitter uses <a href="http://gdal.org">GDAL</a>, <a href="http://leafletjs.com">Leaflet</a>, <a href="http://rubyonrails.org">Ruby on Rails</a>, <a href="http://imagemagick.org">ImageMagick</a>, and other open source software, and makes extensive use of the open source font <a href="http://www.theleagueofmoveabletype.com/junction">Junction</a>.</p>
<p>
+ MapKnitter uses <a href="http://gdal.org">GDAL</a>, <a href="http://leafletjs.com">Leaflet</a>, <a href="http://rubyonrails.org">Ruby on Rails</a>, <a href="http://imagemagick.org">ImageMagick</a>, and other open source software, and makes extensive use of the open source font <a href="http://www.theleagueofmoveabletype.com/junction">Junction</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of having this in one huge line, but let's wait on someone elses review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alaxalves. What would be your preferred solution, because it does look good to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just break the lines, that's all.

@alaxalves
Copy link
Member

Apparently there already has a merge solving this in #586. I don't know how to proceed. 😄 😄 but it seems that #586 has been done before this one, maybe you could get another fto issue @nycbeardo ;)

@alaxalves alaxalves mentioned this pull request May 15, 2019
5 tasks
@nycbeardo
Copy link
Author

@alaxalves thank you for letting me know and the info you provided! I got nervous about this one

Copy link
Member

@theghostyced theghostyced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sashadev-sky
Copy link
Member

sashadev-sky commented Jun 13, 2019

Hi @nycbeardo sorry that this issue had a PR open already. Would you like me to create a new one for you? If so just comment in our plots2 FTO tracker and say you're looking for a mapknitter issue: publiclab/plots2#4963

Or you can get to work on one that is currently opened in another repo: publiclab/leaflet-environmental-layers#177

One quick tip is in order to get your PR noticed, you must link the original issue in the line that says Fixes #0000 (just replace 0000 with the issue number). You'll want to do this in any PR!

Closing this PR due to duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants