-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _footer.html.erb #606
Conversation
added RSS feed links to Update_footer
Thanks for opening this pull request! |
Code Climate has analyzed commit 82cb7fe and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 71.22% 71.22%
=======================================
Files 32 32
Lines 1279 1279
=======================================
Hits 911 911
Misses 368 368 |
@nycbeardo Could this edit the template and link the issue you've solved and such? Thnx 😄 |
Hey @nycbeardo I meant to link the issue like this: Fixes #434. Make sure you do this on your next MRs. Anyway this look ok to me ;) |
<p> | ||
MapKnitter uses <a href="http://gdal.org">GDAL</a>, <a href="http://leafletjs.com">Leaflet</a>, <a href="http://rubyonrails.org">Ruby on Rails</a>, <a href="http://imagemagick.org">ImageMagick</a>, and other open source software, and makes extensive use of the open source font <a href="http://www.theleagueofmoveabletype.com/junction">Junction</a>.</p> | ||
<p> | ||
+ MapKnitter uses <a href="http://gdal.org">GDAL</a>, <a href="http://leafletjs.com">Leaflet</a>, <a href="http://rubyonrails.org">Ruby on Rails</a>, <a href="http://imagemagick.org">ImageMagick</a>, and other open source software, and makes extensive use of the open source font <a href="http://www.theleagueofmoveabletype.com/junction">Junction</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the idea of having this in one huge line, but let's wait on someone elses review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alaxalves. What would be your preferred solution, because it does look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just break the lines, that's all.
Apparently there already has a merge solving this in #586. I don't know how to proceed. 😄 😄 but it seems that #586 has been done before this one, maybe you could get another fto issue @nycbeardo ;) |
@alaxalves thank you for letting me know and the info you provided! I got nervous about this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @nycbeardo sorry that this issue had a PR open already. Would you like me to create a new one for you? If so just comment in our plots2 FTO tracker and say you're looking for a mapknitter issue: publiclab/plots2#4963 Or you can get to work on one that is currently opened in another repo: publiclab/leaflet-environmental-layers#177 One quick tip is in order to get your PR noticed, you must link the original issue in the line that says Fixes #0000 (just replace 0000 with the issue number). You'll want to do this in any PR! Closing this PR due to duplication |
added RSS feed links to Update_footer
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!