Integrating Leaflet-Environmental-Library . #269
Conversation
ghost
assigned 
|
How does this look ?
|
|
@jywarren ...in the map there are 2 grey lines (see pic above) . What could be the possible reason ? |
|
Hi @jywarren ...can you confirm this by running on localhost ?Thanks ! |
|
The grey lines appear even if i remove the leaflet-environmental-layers completely . |
|
Okay Finally found --- its because of Bootstrap's CSS that adds those grey spaces in leaflet map . |
|
Hi ...there seems to be no way of disabling the inheritance of CSS property . If used outside Bootstrap grid : |
|
Oh, that's unfortunate. Can you link to anyone else having this issue, or docs? I feel we should be able to override the CSS... do you know what rule in particular is causing it? |
|
This is the same issue : And this is related issue : I am not able to find which CSS in bootstrap is causing this . |
|
Hi @sagarpreet-chadha sorry i couldn't work on this earlier, but i like your solution of just putting it full-width above the grid. Let's do that! |
|
Done @jywarren ...kindly review this 👍 . |
|
Could you screenshot? Thank you!!! |
|
Screenshot :
|
|
And reminder : to run |
|
Hi! Do you think we could make it completely full width - like 100% of the
window?
Looking great! I'm also wondering about the markers, when they overlap a
lot they kind of get hard to see. Maybe we should try to use the default
Leaflet ones, but see if we can make them smaller, or recolor them red?
Just an idea. But would that happen upstream in the library itself?
…On Thu, Jul 12, 2018 at 1:12 PM Sagarpreet Chadha ***@***.***> wrote:
And reminder : to run bower install 😄 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#269 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ8Wh0KGffZjzAZXuNKzLSpAwbN1Vks5uF4NcgaJpZM4VGQ_G>
.
|
|
HI ! |
|
How does this look ? |
| @@ -29,7 +29,8 @@ | |||
| "glfx-js": "git+https://github.com/jywarren/glfx.js.git", | |||
| "webgl-distort": "jywarren/webgl-distort", | |||
| "image-sequencer": "git+https://github.com/publiclab/image-sequencer.git#~1.4.0", | |||
| "junction": "theleagueof/junction" | |||
| "junction": "theleagueof/junction", | |||
| "leaflet-environmental-layers": "*" | |||
There was a problem hiding this comment.
This will take latest version always , right ?
Can you confirm this @jywarren ?
|
I'm not familiar with that syntax but bower.io should describe it. You
could also go with `^1.0.0` and I think it'll take anything starting with
1.x.x -- again, bower.io should have the syntax for this.
…On Thu, Jul 12, 2018 at 2:24 PM Sagarpreet Chadha ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In bower.json
<#269 (comment)>:
> @@ -29,7 +29,8 @@
"glfx-js": "git+https://github.com/jywarren/glfx.js.git",
"webgl-distort": "jywarren/webgl-distort",
"image-sequencer": "git+https://github.com/publiclab/image-sequencer.git#~1.4.0",
- "junction": "theleagueof/junction"
+ "junction": "theleagueof/junction",
+ "leaflet-environmental-layers": "*"
This will take latest version always , right ?
Can you confirm this @jywarren <https://github.com/jywarren> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#269 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJxsGNsR7NUfexLJ7FucK8Bv3fpQpks5uF5Q3gaJpZM4VGQ_G>
.
|
|
Yeah this looks awesome. Great work! |
|
I think we can merge this and then just not yet deploy to MK until we're ready in the upstream library. Going ahead! Thanks!!! |
#268
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake testThanks!