Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Leaflet-Environmental-Library . #268

Open
sagarpreet-chadha opened this issue Jul 4, 2018 · 11 comments
Open

Integrating Leaflet-Environmental-Library . #268

sagarpreet-chadha opened this issue Jul 4, 2018 · 11 comments

Comments

@sagarpreet-chadha
Copy link
Contributor

Continued from publiclab/leaflet-environmental-layers#18

Link to npm : https://www.npmjs.com/package/leaflet-environmental-layers

Prototype :

image

@sagarpreet-chadha
Copy link
Contributor Author

Hi @jywarren ...I guess we have to add the library to bower too .

@jywarren
Copy link
Member

jywarren commented Jul 5, 2018

I think that's right. Give it a try? 👍

@jywarren
Copy link
Member

Looking good on production!

screen shot 2018-07-18 at 9 38 29 am

A couple small issues:

  1. looks like non-latin characters are converted to ??? maybe?
  2. looks like the click-through to get to the actual map is not working?

Looks amazing though!!!

@jywarren
Copy link
Member

Let's also add a few follow-ups!

  • let's make the other layers visible in the layers menu, so you can turn them on
  • let's make usernames appear on the popups?
  • let's make the current view on that map (after zooming and panning) embeddable on other pages with a </> button!

@sagarpreet-chadha
Copy link
Contributor Author

Thanks 😄 .
Working on follow ups !!!

@sagarpreet-chadha
Copy link
Contributor Author

In the API , the location in non-latin characters are converted to ??????? :

screen shot 2018-07-19 at 12 34 06 pm

Should i open a new issue on plots2 ?

@jywarren
Copy link
Member

Ah, yes i think we should! But is this the MapKnitter api, not plots2? sorry, we're doing so many things at once!

@jywarren
Copy link
Member

jywarren commented Aug 4, 2018

Just FYI i published MapKnitter again yesterday!

@jywarren
Copy link
Member

jywarren commented Aug 4, 2018

And just adding one more -- we should either:

  1. display only maps that have images (this would be an API change or parameter?)
  2. display how many images maps have, in their info bubble

@grvsachdeva
Copy link
Member

Hi @jywarren @sagarpreet-chadha, you want to update the checklist so that new issues can be formed from here? Thanks!

@SidharthBansal
Copy link
Member

Part of #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants