Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests added #943

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Tests added #943

merged 1 commit into from
Mar 27, 2019

Conversation

aashna27
Copy link

@aashna27 aashna27 commented Mar 25, 2019

Ref: #917
I have added test for text overlay and also modified those of other modules as per the new version.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@aashna27
Copy link
Author

image

image

image

image

image

image

image

image

@aashna27 aashna27 requested a review from jywarren March 26, 2019 08:42
@aashna27
Copy link
Author

@jywarren please have a look at text overlay test and then this is ready to merge .

@jywarren jywarren merged commit 8ad171e into publiclab:main Mar 27, 2019
@jywarren
Copy link
Member

🎉🎉

@aashna27 aashna27 mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants