Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Module Selector Console Error #1543

Merged
merged 9 commits into from
Sep 14, 2021
Merged

Fixes Module Selector Console Error #1543

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
77d4fba
fixes console error module selector
ss62171 Jan 19, 2020
11f5dfa
Merge branch 'main' into console_error
rishabhshuklax Jan 22, 2020
1dfaa78
Merge branch 'main' into console_error
rishabhshuklax Feb 3, 2020
49dff4d
Merge branch 'main' into console_error
harshkhandeparkar Jul 8, 2020
5de1a3d
Merge branch 'main' into console_error
harshkhandeparkar Oct 15, 2020
11f9126
Merge branch 'main' into console_error
harshkhandeparkar Oct 15, 2020
bf5e83b
Merge branch 'main' into console_error
harshkhandeparkar Jan 14, 2021
3a9bf91
Merge branch 'main' into console_error
harshkhandeparkar Jul 27, 2021
d0f21d2
Merge branch 'main' into console_error
jywarren Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions examples/lib/defaultHtmlSequencerUi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ function DefaultHtmlSequencerUi(_sequencer, options) {
// look up needed steps from Url Hash:
function importStepsFromUrlHash() {
var hash = urlHash.getUrlHashParameter('steps');

if (hash) {
_sequencer.importString(hash);
_sequencer.run({ index: 0 });
Expand All @@ -27,9 +26,7 @@ function DefaultHtmlSequencerUi(_sequencer, options) {

function selectNewStepUi() {
var m = $(addStepSel + ' select').val();
//if so that whenever the module dropdown is empty it will not show error it will take first value.
if(!m) m = arguments[0];
else $(addStepSel + ' .info').html(_sequencer.modulesInfo(m).description);
if(m) $(addStepSel + ' .info').html(_sequencer.modulesInfo(m).description);
$(addStepSel + ' #add-step-btn').prop('disabled', false);
}

Expand Down