-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Module Selector Console Error #1543
Conversation
Thanks for opening this pull request! |
3 similar comments
Thanks for opening this pull request! |
Thanks for opening this pull request! |
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1543 +/- ##
==========================================
- Coverage 66.67% 65.41% -1.27%
==========================================
Files 130 132 +2
Lines 2686 2741 +55
Branches 433 438 +5
==========================================
+ Hits 1791 1793 +2
- Misses 895 948 +53
|
db9454e
to
77d4fba
Compare
@harshkhandeparkar can you please review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Congrats on merging your first pull request! 🙌🎉⚡️ |
Thank you so much!!!! 🎉 |
Fixes #1531 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!