Update Module.js #1091
Closed
Update Module.js #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added var keyword on lines 41. 45 and 49 as requested in #1084
Codecov Report
@@ Coverage Diff @@
## main #1091 +/- ##
=======================================
Coverage 56.48% 56.48%
=======================================
Files 110 110
Lines 2268 2268
Branches 357 357
=======================================
Hits 1281 1281
Misses 987 987
|
|
@tudoranghelina91 this is all really great, but I am afraid someone else had claimed it before. |
Thank you for your reply |
aashna27
requested changes
Jun 5, 2019
| @@ -38,15 +38,15 @@ module.exports = function ColorTemperature(options, UI) { | |||
| for (let i = 0; i < pixels.shape[0]; i++) { | |||
| for (let j = 0; j < pixels.shape[1]; j++) { | |||
|
|
|||
| r_data = pixels.get(i, j, 0); | |||
| var r_data = pixels.get(i, j, 0); | |||
There was a problem hiding this comment.
the is a comma at the end so that the var can be shared with the other variable
There was a problem hiding this comment.
Hello, @aashna27 , could you please elaborate?
harshkhandeparkar
approved these changes
Aug 29, 2019
|
Not required anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added var keyword on lines 41. 45 and 49 as requested in #1084
Fixes #0000 (<=== Replace
0000with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!