Solve no-undef errors #1084

aashna27 · 2019-05-27T20:55:11Z

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

To gain a sense of what the issue targets go to .eslintrc.js and comment the no-undef': 0 rule and the go to your terminal and run below command.

npx eslint .

You will see a list of no-undef errors and by this issue we plan to reduce those errors.

📝 Update the following files

ReplaceImage.js add const $ = window.$; at line 4 in ReplaceImage()
Ui.js add const $ = window.$; at line 3 in CropModuleUi()
Crop.js and modify line 20 as

-backgroundColor = options.backgroundColor.split(' ');
+var backgroundColor = options.backgroundColor.split(' ');

Module.js and change line 7

-  getPixels = require('get-pixels');
+ var getPixels = require('get-pixels');

Module.js and add as

function extraManipulation(pixels) {
+       const $ = window.$;
      var i = 0, sum = [0, 0, 0, 0];

Module.js as

-r_data = pixels.get(i, j, 0);
+var r_data = pixels.get(i, j, 0),
r_new_data = (255 / r) * r_data;
pixels.set(i, j, 0, r_new_data);

-g_data = pixels.get(i, j, 1);
+var g_data = pixels.get(i, j, 1),
g_new_data = (255 / g) * g_data;
pixels.set(i, j, 1, g_new_data);

-b_data = pixels.get(i, j, 2);
+var b_data = pixels.get(i, j, 2),
b_new_data = (255 / b) * b_data;
pixels.set(i, j, 2, b_new_data);

Convolution.js

-for (i = 0; i < 9; i++) {
+for(var i=0; i < 9; i++) {
    kernelValues[i] = Number(kernelValues[i]) * constantFactor;
  }
-for (y = 0; y < 3; y++) {
+for (var y = 0; y < 3; y++) {

-for (x = 0; x < 3; x++) {
+for(var x = 0; x < 3; x++) {

As explained similar changes can be made for many others files to bring down the number of errors (no-undef) for files SetInputStep, Module.js, and many others. The errors can be seen in the terminal using npx eslint . and similar changes can be made in files.

💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

The text was updated successfully, but these errors were encountered:

sreekaransrinath · 2019-05-28T12:37:09Z

Hey! I'd like to work on this issue :)

harshkhandeparkar · 2019-05-28T12:38:02Z

Go ahead!

sreekaransrinath · 2019-05-28T13:02:31Z

Hey so there are three different Ui.js files, and two of them have a cropmoduleui function. Do I need to update both of them?

Similar issue with Module.js, there seem to be 20-odd different Module.js files

harshkhandeparkar · 2019-05-28T13:05:05Z

Yes

…

On Tue 28 May, 2019, 6:32 PM skaranzx16, ***@***.***> wrote: Hey so there are three different Ui.js files, and two of them have a cropmoduleui function. Do I eed to update both of them? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1084?email_source=notifications&email_token=AIJI5H5M6PXMEUECT3V2UG3PXUUOTA5CNFSM4HP6LCJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWMBQBI#issuecomment-496506885>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJI5H45TXDRF2RYIX23MB3PXUUOTANCNFSM4HP6LCJQ> .

harshkhandeparkar · 2019-05-28T13:05:59Z

I guess you have to fix all the errors. You can edit any file. Cc @aashna27

…

On Tue 28 May, 2019, 6:34 PM M K, ***@***.***> wrote: Yes On Tue 28 May, 2019, 6:32 PM skaranzx16, ***@***.***> wrote: > Hey so there are three different Ui.js files, and two of them have a > cropmoduleui function. Do I eed to update both of them? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#1084?email_source=notifications&email_token=AIJI5H5M6PXMEUECT3V2UG3PXUUOTA5CNFSM4HP6LCJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWMBQBI#issuecomment-496506885>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AIJI5H45TXDRF2RYIX23MB3PXUUOTANCNFSM4HP6LCJQ> > . >

aashna27 · 2019-05-28T18:44:07Z

@PoseidonSigmaX I have linked each file to their respective location, the links for each will take you to the required place.I hope I am making sense.

sreekaransrinath · 2019-05-31T09:32:19Z

@aashna27 In edit 6 you've placed a comma at the end of the lines to be added. I'm assuming you meant to put a semicolon there.

Also thank you for linking the files it was really confusing before

The file to edit for edit 7 isn't mentioned. Could you look into that please?

aashna27 · 2019-06-03T19:24:27Z

@aashna27 In edit 6 you've placed a comma at the end of the lines to be added. I'm assuming you meant to put a semicolon there.

Also thank you for linking the files it was really confusing before
* The file to edit for edit 7 isn't mentioned. Could you look into that please?

Nope its a comma not a ; and yes I have now linked for 7th edit as well . Also these variable changes exist in many other files as well so it would be good if you would like to do it for other files as well.

Starkyv · 2019-09-16T04:10:37Z

Can I take up this issue?

jywarren · 2019-09-25T22:31:03Z

We'd love your help! Sorry for the slow reply!

…

On Mon, Sep 16, 2019 at 12:11 AM Starkyv ***@***.***> wrote: Can I take up this issue? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1084?email_source=notifications&email_token=AAAF6J4OLIUG63MUQGRSLADQJ4BL3A5CNFSM4HP6LCJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6YBWQA#issuecomment-531635008>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J5XIXLP3KWMEWMFST3QJ4BL3ANCNFSM4HP6LCJQ> .

rahulzura · 2019-10-12T17:08:53Z

Can I take this issue or is anyone working on it?

harshkhandeparkar · 2019-10-12T17:55:53Z

You can work on it. Just make sure that no one else is working on it.

…

On Sat, 12 Oct, 2019, 10:38 PM Rahul Kumar, ***@***.***> wrote: Can I take this issue or is anyone working on it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1084?email_source=notifications&email_token=AIJI5H2BILNVZYMUIKYOVPLQOIACPA5CNFSM4HP6LCJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCD6ZY#issuecomment-541343591>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJI5H4JTWZZNQSZOKUPWTTQOIACPANCNFSM4HP6LCJQ> .

harshkhandeparkar · 2019-10-26T11:43:37Z

I think this was fixed

aashna27 added first-timers-only coding Issue related to code code-cleaning labels May 27, 2019

aashna27 mentioned this issue May 27, 2019

Create first-timers-only issues for newcomers #842

Closed

17 tasks

This was referenced May 28, 2019

Update Module.js #1089

Closed

Update Module.js #1091

Closed

harshkhandeparkar closed this as completed Oct 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solve no-undef errors #1084

Solve no-undef errors #1084

aashna27 commented May 27, 2019 •

edited

Loading

sreekaransrinath commented May 28, 2019

harshkhandeparkar commented May 28, 2019

sreekaransrinath commented May 28, 2019 •

edited

Loading

harshkhandeparkar commented May 28, 2019 via email

harshkhandeparkar commented May 28, 2019 via email

aashna27 commented May 28, 2019

sreekaransrinath commented May 31, 2019 •

edited

Loading

aashna27 commented Jun 3, 2019

Starkyv commented Sep 16, 2019

jywarren commented Sep 25, 2019 via email

rahulzura commented Oct 12, 2019

harshkhandeparkar commented Oct 12, 2019 via email

harshkhandeparkar commented Oct 26, 2019

Solve no-undef errors #1084

Solve no-undef errors #1084

Comments

aashna27 commented May 27, 2019 • edited Loading

🤔 What you will need to know.

📋 Step by Step

Please keep us updated

Is someone else already working on this?

🤔❓ Questions?

sreekaransrinath commented May 28, 2019

harshkhandeparkar commented May 28, 2019

sreekaransrinath commented May 28, 2019 • edited Loading

harshkhandeparkar commented May 28, 2019 via email

harshkhandeparkar commented May 28, 2019 via email

aashna27 commented May 28, 2019

sreekaransrinath commented May 31, 2019 • edited Loading

aashna27 commented Jun 3, 2019

Starkyv commented Sep 16, 2019

jywarren commented Sep 25, 2019 via email

rahulzura commented Oct 12, 2019

harshkhandeparkar commented Oct 12, 2019 via email

harshkhandeparkar commented Oct 26, 2019

aashna27 commented May 27, 2019 •

edited

Loading

sreekaransrinath commented May 28, 2019 •

edited

Loading

sreekaransrinath commented May 31, 2019 •

edited

Loading