-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed style on dropdown button in custom insert popover #802
Conversation
Regarding first-timers-only issue: publiclab#798
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Hi @Innominata88, you did a great job. You need to run
|
@TildaDares Thanks so much for the feedback and I apologize for the delay. I was able to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were able to figure it out @Innominata88. Great work!
@Innominata88 Can you remove the |
@TildaDares I am so sorry I just saw your message. I had not had a chance to get on here and I must have missed the email notification. I have updated the file as you requested and will check back to ensure this worked. Again, I really appreciate your patience and the time you have taken explaining everything to me and apologize for the delay. |
Hi @Innominata88, that's fine. I think the |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Great work @Innominata88! |
Regarding first-timers-only issue:
#798
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt jasmine
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!