Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed style on dropdown button in custom insert popover #802

Merged
merged 8 commits into from
Feb 9, 2022

Conversation

Innominata88
Copy link
Contributor

Regarding first-timers-only issue:
#798

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Jan 22, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@TildaDares
Copy link
Member

Hi @Innominata88, you did a great job. You need to run grunt build after adding a change.

Make changes to the files in the /src/ directory, then run grunt build to compile into /dist/PublicLab.Editor.js. This will use grunt-browserify to concatenate and include any node modules named in require() statements.

@gitpod-io
Copy link

gitpod-io bot commented Jan 28, 2022

@Innominata88
Copy link
Contributor Author

@TildaDares Thanks so much for the feedback and I apologize for the delay. I was able to run grunt build locally, but I have not been able to figure out how to revise this pull request since I did not run that prior to opening this pr. Could you please walk me through how I can correct this? I'm still a Git newbie and would really appreciate it. Thank you!

@TildaDares TildaDares linked an issue Jan 28, 2022 that may be closed by this pull request
5 tasks
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were able to figure it out @Innominata88. Great work!

@TildaDares
Copy link
Member

@Innominata88 Can you remove the package-lock.json file from this PR? You can do that by copying the package-lock.json file contents from this repo and pasting it in your own local file. Then commit and push. Thanks!

@Innominata88
Copy link
Contributor Author

@TildaDares I am so sorry I just saw your message. I had not had a chance to get on here and I must have missed the email notification. I have updated the file as you requested and will check back to ensure this worked.

Again, I really appreciate your patience and the time you have taken explaining everything to me and apologize for the delay.

@TildaDares
Copy link
Member

Hi @Innominata88, that's fine. I think the package-lock.json has been removed.

@TildaDares TildaDares merged commit 22bd38c into publiclab:main Feb 9, 2022
@welcome
Copy link

welcome bot commented Feb 9, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly?
Do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Great work @Innominata88!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropdown button in custom insert popover has no style
2 participants