Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropdown button in custom insert popover has no style #798

Closed
5 tasks
NARUDESIGNS opened this issue Jan 21, 2022 · 8 comments · Fixed by #802
Closed
5 tasks

dropdown button in custom insert popover has no style #798

NARUDESIGNS opened this issue Jan 21, 2022 · 8 comments · Fixed by #802
Assignees

Comments

@NARUDESIGNS
Copy link
Collaborator

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file PublicLab.CustomInsert.Template.js in the PublicLab.Editor repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

- builder += '<button class="btn btn-outline-secondarydropdown-toggle dropdownMenu2" type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="true" style="min-width: 150px;">';
+ builder += '<button class="btn btn-outline-secondary dropdown-toggle dropdownMenu2" type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="true" style="min-width: 150px;">';
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@NARUDESIGNS
Copy link
Collaborator Author

This button currently looks like this:

Screenshot 2022-01-21 at 10 36 29 AM

After making changes, it should look like this:

Screenshot 2022-01-21 at 10 42 18 AM

cc @TildaDares

@TildaDares
Copy link
Member

This looks good @NARUDESIGNS

@Innominata88
Copy link
Contributor

Innominata88 commented Jan 21, 2022

Has anyone claimed this issue yet? I've been afraid to take the plunge and contribute to an open source repo and this seems like a good opportunity to gain some confidence since you all seem so friendly and helpful. :)

Edit: I went ahead and gave this a shot and made a mistake on the branches. As you can probably see below, I seemed to make things worse by trying to "fix" it! :) I would appreciate any advice you might have about how I should have handled that since I will definitely be on the lookout for anything I might be able to contribute to your codebase in the future. Thank you very much for having such a welcoming program set up to ease newbies like me into this!

@bittu426
Copy link

Hello, I'm Chaitanya and I've been asked to contribute to an open-source project for my Software Development course. I'm interested to work on this issue and it'd be great if I could be assigned to this. Thank you so much.

@TildaDares
Copy link
Member

Hi @bittu426, there’s an open issue for you to work on in publiclab/spectral-workbench#858 if you’re interested.

@bittu426
Copy link

Yes. I'm interested. Can I be assigned for that issue?

@TildaDares
Copy link
Member

@bittu426 Leave a comment in the issue and if no one has claimed it you can start working on it.

@TildaDares TildaDares linked a pull request Jan 28, 2022 that will close this issue
5 tasks
@singla-nitin
Copy link

Hey , has someone been assigned to this issue or can work on it and pls someone guide as to how to do it and move forward as I am totally new to open source and github.
a reply will be appreciated .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants