Add tooltip to Custom Insert button #782
Conversation
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
|
|
|
To fix issue #779 |
| @@ -67,7 +67,13 @@ module.exports = function CustomInsert(_module, wysiwyg) { | |||
| } | |||
| }); | |||
| const builder = require("./PublicLab.CustomInsert.Template.js"); | |||
| $('.wk-commands').append('<a class="woofmark-command-insert btn btn-outline-secondary" data-toggle="Insert" title="Custom Insert"><i class="fa fa-tags"></i></a>'); | |||
|
|
|||
There was a problem hiding this comment.
Good job, just a little change here, line 70 shouldn't be a blank line. That's where the code additions should start.
There was a problem hiding this comment.
Thanks! Is the new commit better?
There was a problem hiding this comment.
Looks good to me!
Well done 🥳
cc @TildaDares
|
/rebase |
|
Just needed to sync this with an upstream test fix and I think it should be good now! |
|
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
|
Great! Merged and many thanks!!! 🎉 |
I need to find similar fix for the wysiwyg PR Also, I noticed my other PRs passes the ui-tests on Github and are fine. Just this one is affected. |
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt jasminefixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!