Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tooltip for custom insert button #779 #780

Closed
wants to merge 1 commit into from

Conversation

mreddyn
Copy link

@mreddyn mreddyn commented Jan 8, 2022

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

fixes issue #779
Thanks!

@welcome
Copy link

welcome bot commented Jan 8, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Jan 8, 2022

@NARUDESIGNS NARUDESIGNS changed the title added tooltip for custom insert button #779 Add tooltip for custom insert button #779 Jan 8, 2022
@NARUDESIGNS NARUDESIGNS changed the title Add tooltip for custom insert button #779 added tooltip for custom insert button #779 Jan 8, 2022
@NARUDESIGNS
Copy link
Collaborator

I'm sorry for altering the title (I've reverted it to yours), I thought this was the FTO issue I raised but I just figured it is your PR. Please can you share a screenshot to show the effect of these changes on your local PublicLab Editor page?
cc @TildaDares

@TildaDares
Copy link
Member

Hi @mreddyn, thank you for your contribution but I'll have to close this issue since #782 has already resolved this. Thanks!

@TildaDares TildaDares closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants