List of small UI bugs to resolve

[jywarren]

Collecting some UI bugs which we should address, potentially breaking them up into sub-issues for solving one by one. If you'd like to repost one individually, please link it from here with a comment, thanks!

• 2 clicks required to show toolbar (should be just one)
• clicking away from an image (onto background) doesn't deselect it
• placement of toolbar should be at position of mouse click

For these three issues, see the gif here for a demonstration:

Thanks!!!

[sashadev-sky]

@jywarren only one more to go here!

Please see first two below (this fixes are all in my multiple image select PR):

[jywarren]

oh wow!!!!

…

On Tue, Mar 19, 2019 at 11:46 AM Sasha Boginsky ***@***.***> wrote: @jywarren <https://github.com/jywarren> only one more to go here! Please see first two below (this fixes are all in my multiple image select PR): [image: bug7] <https://user-images.githubusercontent.com/41092741/54620318-5ec56a00-4a3c-11e9-9963-fb526bfacd92.gif> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#166 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ9fVw7fV-jVGOOYgBZDKrCfUBoB7ks5vYQYggaJpZM4btTgq> .

[sashadev-sky]

@jywarren for this third point, do you think it would be better to just apply some CSS positioning (relative for images absolute for toolbars) or find another implementation? With mouse click the toolbar would end up on top of the image and whereever else

[jywarren]

I think css positioning would be great. I just think there are a couple scenarios, one where the top of the image is off screen, so it's hidden that way, and perhaps a few other edge cases...

…

On Tue, Mar 19, 2019, 11:50 AM Sasha Boginsky ***@***.***> wrote: @jywarren <https://github.com/jywarren> for this third point, do you think it would be better to just apply some CSS positioning (relative for images absolute for toolbars) or find another implementation? With mouse click the toolbar would end up on top of the image and whereever else — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#166 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ08QptCpkX6yzHBfVM2u1uY0wSJqks5vYQc6gaJpZM4btTgq> .

[sashadev-sky]

Yeah that is the one reason I am hesitant about it, this type of implementation can get hacky but I will look into it

[sashadev-sky]

since I was already on mapknitter i just wanted to post documentation of the some current toolbar issues that I will be solving in a new PR (will link it back here)

1. possibility of toolbar overlapping with the handles making them impossible to grab.
2. The current implementation also relies on the image's position (which is unstable) and explains the instability in toolbar position that has been reported before.
3. Zoom levels are not accounted for so if you click on the image to trigger the toolbar to show from a higher zoom level, by the time you zoom back in to the default (13), the toolbar will be out of view
4. Dragged corners are ignored which is another possible way for the toolbar to position itself blocking a corner

This just shows point 1:

[Greg-Tarr]

@sashadev-sky

Hello,

You mentioned that dragged corners are ignored by the toolbar and overlapping.

I fixed this issue: #210

It makes sure no overlapping is possible.

Thanks.

[sashadev-sky]

final point checked off and this is now closed via #210