Various toolbar updates #187
Conversation
|
gifs for Point 2 Toolbar icons: After: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@rexagod looping you in :) |
|
@jywarren @sashadev-sky This looks interesting! I just wanted to chime in here for a second to let you all know that unfortunately it's exams week currently and therefore I'll be busy. But nonetheless, working on this library will be my first priority from the next week on! It's great to see your work here @sashadev-sky! 👍 🙌 Thanks all! |
|
This looks awesome. Ready to merge? Thanks!!!
Good luck with exams @rexagod!!
…On Sun, Mar 31, 2019, 4:39 PM Pranshu Srivastava ***@***.***> wrote:
@jywarren <https://github.com/jywarren> @sashadev-sky
<https://github.com/sashadev-sky> This looks interesting! I just wanted
to chime in here for a second to let you all know that unfortunately it's
exams week currently and therefore I'll be busy. But nonetheless, working
on this library will be my first priority from the next week on!
It's great to see your work here @sashadev-sky
<https://github.com/sashadev-sky>! 👍 🙌
Thanks all!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ0xxOmk4-JB7Jx_jAVPSdLezJzRFks5vcRzpgaJpZM4cUOlI>
.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
And, this should be good to merge once we address that! Thank you!!! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Those extra 2 points I will move into the new PR as well - I will make my PR description list as usual and put them there |
|
That'd be great, splitting this up. Then we can move forward without it
blocking. Thanks!!!
…On Fri, Apr 5, 2019 at 3:29 PM Sasha Boginsky ***@***.***> wrote:
Those extra 2 points I will move into the new PR as well - I will make my
PR description list as usual and put them there
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ29FtzzKFa43T70mJ8i5CrhLS9iEks5vd6PfgaJpZM4cUOlI>
.
|
sashadev-sky
force-pushed
the
toolbar-updates
branch
from
bee9533 to
a149476
Compare
|
@jywarren this is ready to merge. Fixed here are the 3 issues we agreed to leave, mentioned in the PR description. double-checked that only these relevant updates are made here and they still work. I moved everything else - including comments and gifs into #201 so you can see clearly what is related to this PR. I'll worry about rebasing #201 later 😅 |
references #158, #27 , #126, publiclab/mapknitter#300
Status:
In my previous PR Multiple Image Select #158 I added deselection on map click, but this did not work for the RotateHandles. Deselection might have not worked at all actually. Sorry for this bug! This is now fixed.
When the toolbar icon swaps between the DistortHandles and RotateHandles, the actual icon does not update until you click on the image. This is now fixed. (See below)
change rotate/distort icons in Toolbar when using hotkeys change rotate/distort icons in Toolbar when using hotkeys #27 - fixed (find gif in issue)