Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify_ethereum_text() for ledger? #558

Conversation

humanalgorithm
Copy link
Contributor

No description provided.

@github-actions
Copy link

Cosm-Orc Gas Usage

No gas diff larger than 0.5%

Raw Report for 9747088
Contract Op Name Gas Used Gas Wanted File
vending_factory Instantiate__factory_inst 187123 257618 e2e/src/helpers/helper.rs:35
vending_factory Store__Store 3046089 4545993 e2e/src/helpers/chain.rs:78
vending_factory Execute__factory_exec_minter_inst_w_trading_time 3851665 5754291 e2e/src/tests/factory_test.rs:244
vending_factory Execute__factory_exec_minter_inst 34031382 51023840 e2e/src/tests/factory_test.rs:98
base_factory Store__Store 2667815 3978582 e2e/src/helpers/chain.rs:78
base_minter Store__Store 7003758 10482437 e2e/src/helpers/chain.rs:78
sg721_base Store__Store 7988170 11959055 e2e/src/helpers/chain.rs:78
sg721_metadata_onchain Store__Store 8357091 12512432 e2e/src/helpers/chain.rs:78
sg721_nt Store__Store 7511551 11244126 e2e/src/helpers/chain.rs:78
sg721_updatable Store__Store 8168597 12229695 e2e/src/helpers/chain.rs:78
sg_whitelist Store__Store 3589450 5361035 e2e/src/helpers/chain.rs:78
sg_whitelist_flex Store__Store 3524099 5263008 e2e/src/helpers/chain.rs:78
vending_minter Store__Store 8742508 13090562 e2e/src/helpers/chain.rs:78
vending_minter_wl_flex Store__Store 8907205 13337607 e2e/src/helpers/chain.rs:78
whitelist_immutable Store__Store 2197735 3273462 e2e/src/helpers/chain.rs:78
multiple_contracts Execute__minter_batch_exec_mint_token_w_trading_time 1949634 2894586 e2e/src/tests/factory_test.rs:314
multiple_contracts Execute__minter_batch_exec_mint_token 18804922 28182644 e2e/src/tests/factory_test.rs:164

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (3da0d58) 57.98% compared to head (9747088) 57.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   57.98%   57.94%   -0.04%     
==========================================
  Files          72       72              
  Lines        3320     3322       +2     
==========================================
  Hits         1925     1925              
- Misses       1395     1397       +2     
Impacted Files Coverage Δ
packages/ethereum-verify/src/decode.rs 66.66% <0.00%> (-6.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

⚠️ The sha of the head commit of this PR conflicts with #557. Mergify cannot evaluate rules on this PR. ⚠️

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2023

⚠️ The sha of the head commit of this PR conflicts with #557. Mergify cannot evaluate rules on this PR. ⚠️

@shanev shanev marked this pull request as draft June 4, 2023 21:58
@jhernandezb jhernandezb deleted the humanalgorithm/fix-verify_ethereum_text-for-ledger branch December 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants