Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify_ethereum_text() for Ledger #557

Conversation

@assafmo assafmo changed the title Fix verify_ethereum_text() for ledger Fix verify_ethereum_text() for Ledger Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (3da0d58) 57.98% compared to head (9747088) 57.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   57.98%   57.94%   -0.04%     
==========================================
  Files          72       72              
  Lines        3320     3322       +2     
==========================================
  Hits         1925     1925              
- Misses       1395     1397       +2     
Impacted Files Coverage Δ
packages/ethereum-verify/src/decode.rs 66.66% <0.00%> (-6.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shanev shanev marked this pull request as draft June 4, 2023 21:57
@shanev
Copy link
Member

shanev commented Sep 7, 2023

Closing due to inactivity.

@shanev shanev closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants