Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

取消常规设置必须选择默认下载服务器才能保存数据的限制 #1081

Merged
merged 2 commits into from
Jul 12, 2022
Merged

取消常规设置必须选择默认下载服务器才能保存数据的限制 #1081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dbb7c2
取消常规设置必须选择默认下载服务器才能保存数据的限制
SHL-COOL Jul 4, 2022
163b6ac
修复常规设置保存不弹窗的问题
SHL-COOL Jul 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resource/i18n/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@
},
"base": {
"title": "常规设置",
"defaultClient": "默认下载服务器（必选）",
"defaultClient": "默认下载服务器",
"autoUpdate": "自动更新官方数据",
"save": "保存",
"allowSelectionTextSearch": "启用页面内容选择搜索",
Expand Down
10 changes: 6 additions & 4 deletions src/options/views/settings/Base/Index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,6 @@ export default Vue.extend({
if (!(this.$refs.form as any).validate()) {
this.activeTab = "base";
(this.$refs.defaultClient as any).focus();
return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我倾向于整个都删了，不过删了后也是没法第二次弹出参数已保存的问题（虽然实际有保存到）

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

竟然栽培者执着于让用户选择一个，所以我保留了提示 (只是没有他那么严格)

}

if (!this.options.apiKey) {
Expand Down Expand Up @@ -790,9 +789,12 @@ export default Vue.extend({
).toString();
}
},
watch: {
successMsg() {
this.haveSuccess = this.successMsg != "";
watch: {
successMsg: {
handler() {
this.haveSuccess = this.successMsg != "";
},
deep: true,
},
errorMsg() {
this.haveError = this.errorMsg != "";
Expand Down