Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

取消常规设置必须选择默认下载服务器才能保存数据的限制 #1081

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Conversation

SHL-COOL
Copy link

@SHL-COOL SHL-COOL commented Jul 4, 2022

取消常规设置必须选择默认下载服务器才能保存数据的限制

@ted423
Copy link
Collaborator

ted423 commented Jul 5, 2022

界面仍然显示必选,我个人感觉删return的方式不太好

@SHL-COOL
Copy link
Author

SHL-COOL commented Jul 5, 2022

界面仍然显示必选,我个人感觉删return的方式不太好

因为其他有用到默认下载服务器的地方都有检验是否有设置,所以删除return就可以了,只是之前开发者可能认为必选一下吧😂

@ted423
Copy link
Collaborator

ted423 commented Jul 5, 2022

试了下,第二次保存就不会弹出参数已保存的框了。
原来的正常。
看下R酱那边意见

@@ -560,7 +560,6 @@ export default Vue.extend({
if (!(this.$refs.form as any).validate()) {
this.activeTab = "base";
(this.$refs.defaultClient as any).focus();
return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我倾向于整个都删了,不过删了后也是没法第二次弹出参数已保存的问题(虽然实际有保存到)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

竟然栽培者执着于让用户选择一个,所以我保留了提示 (只是没有他那么严格)

@SHL-COOL
Copy link
Author

SHL-COOL commented Jul 5, 2022

试了下,第二次保存就不会出现R参数已经保存的框了。 原来 的效果。

看了一下是监听的问题,我修改了监听方式,现在是可以了

@SHL-COOL SHL-COOL requested a review from ted423 July 10, 2022 13:36
@ted423 ted423 merged commit 638c443 into pt-plugins:dev Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants