Allow Symfony 6 #227
Merged
Allow Symfony 6 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending Codeception/Codeception#6273 merge. |
|
Symfony 6 will be out very soon, any chance this can be merged? Even if it's not perfect, merely having this in composer is blocking projects using it from even testing with Symfony 6. |
chalasr
force-pushed
the
sf-6
branch
5 times, most recently
from
5c3d24b
to
4cb0083
Compare
|
What can we do to help speed up merging this? Currently, doctrine-bundle can't properly test with symfony 6 packages https://github.com/doctrine/DoctrineBundle/actions/runs/1525271516 |
seferov
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
@chalasr thanks for the contribution. I will try to update https://github.com/psalm/codeception-psalm-module to fix tests for Symfony 6. For now, I am merging this with failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224