Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Symfony 5 stubs are not used anymore when bumping to Symfony 6 #233

Closed
VincentLanglet opened this issue Jan 2, 2022 · 0 comments · Fixed by #234
Closed

The Symfony 5 stubs are not used anymore when bumping to Symfony 6 #233

VincentLanglet opened this issue Jan 2, 2022 · 0 comments · Fixed by #234

Comments

@VincentLanglet
Copy link
Contributor

Hi @seferov,

Since #227 from @chalasr, Symfony 6 is supported ; but that's not really true.

Here https://github.com/psalm/psalm-plugin-symfony/blob/master/src/Plugin.php#L74 is loading

__DIR__.'/Stubs/'.Kernel::MAJOR_VERSION

which doesn't exist for Symfony 6.

But all the stubs in the Symfony 5 folder are still valid for Symfony 6.

What's the best strategy ? Duplicating the '5' older into a '6' folder ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant