Backport #563, #564, #565 to v0.46.x and mark v0.46.10-pio-3 in the changelog. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dings-tags expand additional_bindings so they can be parsed with protobufjs
…te-listening remove listener lock as there is no concurrency
* add injection of attribute checking...still POC atm * expect restricted function to only return err, refactor names * move send restrictions check to SendCoins * remove line that was missed during refactor * add code comments * move accept logic to msg server * Revert "add code comments" This reverts commit d88da38. * revert ensure restirctions function into send keeper, add restrictions check to mult-send * add back send enable checks to msg server * add change log
|
I ran the following |
nullpointer0x00
approved these changes
Mar 21, 2023
iramiller
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of the following to
release-pio/v0.46.x:Also, update the changelog and release notes to reflect
v0.46.10-pio-3, which will I will tag after this merges.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change