Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove listener lock as there is no concurrency #565

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

egaxhaj
Copy link

@egaxhaj egaxhaj commented Mar 15, 2023

Removes locks on state listening because there's no concurrency risk.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@egaxhaj egaxhaj merged commit 72a21a6 into main-pio Mar 15, 2023
SpicyLemon pushed a commit that referenced this pull request Mar 20, 2023
…te-listening

remove listener lock as there is no concurrency
SpicyLemon added a commit that referenced this pull request Mar 21, 2023
…hangelog. (#566)

* Merge pull request #564 from provenance-io/egaxhaj/fix-additional-bindings-tags

expand additional_bindings so they can be parsed with protobufjs

* Merge pull request #565 from provenance-io/egaxhaj/remove-lock-on-state-listening

remove listener lock as there is no concurrency

* 1256 support for tokens restricted with attributes (#563)

* add injection of attribute checking...still POC atm

* expect restricted function to only return err, refactor names

* move send restrictions check to SendCoins

* remove line that was missed during refactor

* add code comments

* move accept logic to msg server

* Revert "add code comments"

This reverts commit d88da38.

* revert ensure restirctions function into send keeper, add restrictions check to mult-send

* add back send enable checks to msg server

* add change log

* Mark v0.46.10-pio-3 in the changelog and release notes.

---------

Co-authored-by: Ergels Gaxhaj <87285445+egaxhaj@users.noreply.github.com>
Co-authored-by: Carlton Hanna <nullpointer0x00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants