-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Ruby 3.2 to the CI matrix #438
Adds Ruby 3.2 to the CI matrix #438
Conversation
Thanks for the contribution, @petergoldstein! I was kinda waiting for #433 before releasing a new version, but you're right -- it's been a long time since a release 👍 |
I don't have the machine I normally use, will try to release over the weekend. |
@ashkulz Sounds good. Once that's done I can put up PRs that add Ruby 3.1 and 3.2 to CI for all the assorted pronto gems. |
Release |
@ashkulz Great. I've submitted PRs for everything but |
@petergoldstein thanks for all the PRs, I've merged all of them 🎉 |
@ashkulz Great. Thanks. Not exactly sure why pronto-rubocop is failing - it's failing now across all Rubies, presumably because of a change in |
@petergoldstein did you update your fork? I fixed a similar-sounding issue in prontolabs/pronto-rubocop@36c6acc 🤔 |
@ashkulz I hadn't caught that update. I'll rebase and see if that resolves the issue. Thanks! |
@ashkulz Yep, that was it. Submitted I'm not clear if I think that's it for me. Thanks for merging all of these PRs. |
Dear @mmozuras, Who has commit and release permission for Poper gem? If possible, could add more contributors like @petergoldstein and @ashkulz? |
@petergoldstein, thanks for working on them -- happy new year in advance! |
Also updates checkout action version.
The current published version of
pronto
is not compatible with Ruby 3.2, because of therugged
dependency. Rugged only became Ruby 3.2 compliant as of version 1.4.2 or so. If would be great to have this merged and a new gem version published.Currently this is blocking some compatibility efforts on https://github.com/JEG2/highline , so an updated gem would definitely be appreciated.
cc: @abinoam