Relax octokit version dependency #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelicka
approved these changes
Sep 15, 2022
avelicka
approved these changes
Sep 15, 2022
ashkulz
requested changes
Sep 16, 2022
|
Changed octokit dependency to be |
tomasv
approved these changes
Nov 8, 2022
ashkulz
requested changes
Nov 9, 2022
There was a problem hiding this comment.
I wouldn't like to drop support for Ruby 2.6 although it's EOL, because that's the currently supported JRuby version.
Dropping support for old Ruby versions will also be problematic, as that'll require a major version bump. Is there a way to fix the CI without doing all this?
|
Any update, @andriusm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous constrain was limiting where Danger 9.x cannot be used together with Pronto in a project because of different octokit dependency version requirements. There was also an issue registered suggesting this - #430