Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values for AppProjects #152

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Default values for AppProjects #152

merged 1 commit into from
Feb 29, 2024

Conversation

mhutter
Copy link
Contributor

@mhutter mhutter commented Feb 28, 2024

In many use cases, the AppProject actually look quite similar, or at least include common things (like setting clusterResourceWhitelist: [] to disallow the creation of cluster-scoped resources entirely).

This commit adds the projectDefaults field to ArgoCD instances, allowing users to -- who would have guessed it -- set defaults for their projects.

Follow-up to #151

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@mhutter mhutter added the enhancement New feature or request label Feb 28, 2024
@mhutter mhutter self-assigned this Feb 28, 2024
@mhutter mhutter requested a review from simu February 29, 2024 06:31
In many use cases, the AppProject actually look quite similar, or at
least include common things (like setting `clusterResourceWhitelist: []`
to disallow the creation of cluster-scoped resources entirely).

This commit adds the `projectDefaults` field to ArgoCD instances,
allowing users to -- who would have guessed it -- set defaults for their
projects.

Signed-off-by: Manuel Hutter <manuel@hutter.io>
@mhutter mhutter force-pushed the feat/project-defaults branch from 9ce2b8b to 3448b25 Compare February 29, 2024 11:38
@mhutter mhutter marked this pull request as ready for review February 29, 2024 11:38
@simu simu changed the title feat: Default values for AppProjects Default values for AppProjects Feb 29, 2024
@mhutter mhutter merged commit 0862794 into master Feb 29, 2024
10 checks passed
@mhutter mhutter deleted the feat/project-defaults branch February 29, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants