Allow creation of ArgoCDs and AppProjects #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll reuse an existing golden-test to reduce the amount of crap in here |
mhutter
force-pushed
the
feat/instances
branch
from
588432f to
36e0972
Compare
mhutter
force-pushed
the
feat/instances
branch
from
36e0972 to
d75a4ee
Compare
mhutter
changed the title
While this component already managed the ArgoCD operator and the Syn ArgoCD instance, additional ArgoCD instances could only be deployed as adhoc-manifests. While this works, it is not possible to leverage Syn features such as hierarchical configuration, resulting in quite some duplication. This commit introduces the new parameters `argocds` and `projects`, which allow the creation of `ArgoCD` and `AppProject` instances respectively. In general, the component tries to be as un-intrusive as possible, so we only set minimal default values: For `ArgoCD`: spec.applicationInstanceLabelKey` - if this value collides for two ArgoCD instances on the same cluster, ArgoCD cannot properly determine which resources belong to "itself", and might try to prune resources managed by other ArgoCD instances. Signed-off-by: Manuel Hutter <manuel@hutter.io>
mhutter
force-pushed
the
feat/instances
branch
from
d75a4ee to
722fe06
Compare
simu
reviewed
Feb 28, 2024
simu
reviewed
Feb 28, 2024
|
Thanks for the input @simu, I have updated the PR |
As mentioned in the code review, AppProject resources created usig this component usually only exist within the context of an ArgoCD instance ALSO deployed using this component, so it makes sense to nest these resources. As a side-effect, this allows me to use `instances` as the parameter key, which I prefer :-) Additionally we now validate that no two instances are deployed to the same namespace. Signed-off-by: Manuel Hutter <manuel@hutter.io>
mhutter
force-pushed
the
feat/instances
branch
from
b6143e1 to
c4c54e5
Compare
simu
changed the title
simu
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this component already managed the ArgoCD operator and the Syn ArgoCD instance, additional ArgoCD instances could only be deployed as adhoc-manifests. While this works, it is not possible to leverage Syn features such as hierarchical configuration, resulting in quite some duplication.
This commit introduces the new parameters
argocdsandprojects, which allow the creation ofArgoCDandAppProjectinstances respectively.In general, the component tries to be as un-intrusive as possible, so we only set minimal default values:
For
ArgoCD:spec.applicationInstanceLabelKey- if this value collides for two ArgoCD instances on the same cluster, ArgoCD cannot properly determine which resources belong to "itself", and might try to prune resources managed by other ArgoCD instances.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.