Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename jupyter_viz namespace to solara_viz #2188

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Jul 29, 2024

This is intentionally a separate PR so that it is easier to review.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +0.1% [-0.2%, +0.5%] 🔵 -0.5% [-0.7%, -0.4%]
Schelling large 🔵 -0.3% [-0.8%, +0.3%] 🔵 -1.5% [-2.1%, -0.9%]
WolfSheep small 🔵 -0.4% [-1.5%, +0.9%] 🔵 -1.6% [-1.9%, -1.3%]
WolfSheep large 🔵 -0.6% [-1.0%, -0.3%] 🔵 -1.2% [-1.7%, -0.8%]
BoidFlockers small 🔵 -3.5% [-4.1%, -2.9%] 🔵 -1.4% [-2.1%, -0.7%]
BoidFlockers large 🔵 -3.1% [-3.8%, -2.5%] 🔵 -0.6% [-1.3%, +0.1%]

@EwoutH
Copy link
Member

EwoutH commented Jul 29, 2024

Wait, but if we add a second function/class here (#2187 (comment)), solara_viz is not fitting anymore, right?

@rht
Copy link
Contributor Author

rht commented Jul 29, 2024

A PyGameViz would be in pygame_viz.py. Otherwise it would be hard to read 2 different frameworks in 1 file.

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, looks good

@rht rht merged commit 40dc223 into projectmesa:main Jul 29, 2024
11 of 12 checks passed
@rht rht deleted the solara_viz branch July 29, 2024 20:29
@EwoutH EwoutH added breaking Release notes label enhancement Release notes label and removed breaking Release notes label labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants