Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SolaraViz instead of JupyterViz in examples #155

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

EwoutH
Copy link
Member

@EwoutH EwoutH commented Aug 11, 2024

This updates all the examples to use the renamed and stabilized SolaraViz.

For reference:

@EwoutH EwoutH requested a review from rht August 11, 2024 10:24
This updates all the examples to use the renamed and stabilized SolaraViz.
@rht rht merged commit 78b8a36 into projectmesa:main Aug 11, 2024
3 checks passed
@EwoutH
Copy link
Member Author

EwoutH commented Aug 11, 2024

Thanks for merging!

@@ -1,4 +1,4 @@
from mesa.visualization.jupyter_viz import JupyterViz, Slider, make_text
from mesa.visualization.solara_viz.py import Slider, SolaraViz, make_text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line doesn't work.

Copy link
Member Author

@EwoutH EwoutH Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .py should be removed, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, removing .py fixed it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 274a1bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants