Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Change coord_iter to return tuple[content, pos] #1723

Merged
merged 1 commit into from
Jun 22, 2023
Merged

breaking: Change coord_iter to return tuple[content, pos] #1723

merged 1 commit into from
Jun 22, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented Jun 21, 2023

This PR recreates #1566.

@rht rht mentioned this pull request Jun 21, 2023
Closed
@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0db8f7c) 79.93% compared to head (386d49a) 79.93%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1723   +/-   ##
=======================================
  Coverage   79.93%   79.93%           
=======================================
  Files          18       18           
  Lines        1176     1176           
  Branches      220      220           
=======================================
  Hits          940      940           
  Misses        202      202           
  Partials       34       34
Impacted Files Coverage Δ
mesa/space.py 90.88% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tortar @rht
breaking: Change coord_iter to return tuple[content, pos]
386d49a 
Co-authored-by: rht <rhtbot@protonmail.com>
@rht rht force-pushed the breaking_coord_iter branch from 391489e to 386d49a Compare June 21, 2023 03:47
@rht rht changed the title breaking: Change coord_iter to return Tuple[content, pos] breaking: Change coord_iter to return tuple[content, pos] Jun 21, 2023
tpike3
tpike3 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mesa 2.0 here we come!

@tpike3 tpike3 merged commit f7d91d1 into projectmesa:main Jun 22, 2023
@rht rht deleted the breaking_coord_iter branch June 23, 2023 12:37
@rht rht mentioned this pull request Jun 29, 2023
Closed
@tpike3 tpike3 added this to the Mesa 2.0 (Wellton) milestone Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpike3 tpike3 tpike3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Mesa 2.0 (Wellton)
Development

Successfully merging this pull request may close these issues.
3 participants
@rht @tpike3 @Tortar