-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Grid.coord_iter return content, pos #1566
Conversation
also we can do inside something like |
ok done this way, because seems much better, still need to change/add some tests and maybe the deprecation and changing the name if you have any suggestion |
Codecov ReportBase: 82.05% // Head: 82.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1566 +/- ##
==========================================
- Coverage 82.05% 82.00% -0.05%
==========================================
Files 18 18
Lines 1382 1384 +2
Branches 270 270
==========================================
+ Hits 1134 1135 +1
- Misses 204 205 +1
Partials 44 44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We probably should just do a breaking change to |
Agree, all should be ok for merging in 2.0. :-) |
Redone in #1723, because handling the merge conflict takes longer. |
All the examples which use
coord_iter
transform the output so that to have apos
tuple, this should be avoided, right now I changed coord_iter, so this is a breaking change, but we can even (probably better) deprecate this method and create a new one with a new name, what do you suggest as new name @rht, @Corvince?pos_iter
?