Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify ChartModule series to allow dynamically named properties #1685

Merged
merged 1 commit into from
May 9, 2023
Merged

Modify ChartModule series to allow dynamically named properties #1685

merged 1 commit into from
May 9, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented May 9, 2023

Original work: #714 #1673

This was referenced May 9, 2023
Closed
Closed
@rht rht force-pushed the catherinedevline-main branch from d54770d to 96e8277 Compare May 9, 2023 04:57
@codecov
Copy link

codecov bot commented May 9, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (0e9f818) 81.62% compared to head (64799c3) 81.62%.

❗ Current head 64799c3 differs from pull request most recent head 2caf7f4. Consider uploading reports for the commit 2caf7f4 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1685   +/-   ##
=======================================
  Coverage   81.62%   81.62%           
=======================================
  Files          18       18           
  Lines        1399     1399           
  Branches      271      271           
=======================================
  Hits         1142     1142           
  Misses        211      211           
  Partials       46       46

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rht rht force-pushed the catherinedevline-main branch 2 times, most recently from 345f510 to 64799c3 Compare May 9, 2023 05:00
@gotkaren @rht
Modify ChartModule series to allow dynamically named properties
2caf7f4 
Original work: projectmesa#714 and
projectmesa#1673.

Co-authored-by: Karen Gonzalez <karenyglez.tr@gmail.com>
Co-authored-by: rht <rhtbot@protonmail.com>
@rht rht force-pushed the catherinedevline-main branch from 64799c3 to 2caf7f4 Compare May 9, 2023 05:02
@rht rht merged commit c9d0c43 into projectmesa:main May 9, 2023
@rht rht deleted the catherinedevline-main branch May 9, 2023 05:05
@rht
Copy link
Contributor Author

rht commented May 9, 2023

@tpike3 @jackiekazil my mistake for breaking the protocol and merging this PR by myself. Was too focused on clearing the unmerged PR counts that I merged my own PR. I think we should turn the main branch into protected branch?

@rht
Copy link
Contributor Author

rht commented May 9, 2023

Though technically, for this case, this was a re-open PR for #1664, because I wasn't able to edit that PR.

@tpike3
Copy link
Member

tpike3 commented May 9, 2023

It's fine.. pretty straight forward change so no reason to create more work. But yes agree we should make main a protected branch.

@jackiekazil jackiekazil mentioned this pull request May 10, 2023
Closed
@tpike3 tpike3 added this to the Mesa 2.0 (Wellton) milestone Jul 1, 2023
@wang-boyu wang-boyu mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Mesa 2.0 (Wellton)
Development

Successfully merging this pull request may close these issues.
2 participants
@rht @tpike3